Remove ChangeReadOnlyPropertyWithDefaultValueToConstantRector as over…

…ly detailed checks, better use PHPStan and refactor individually (#4028)
rectorphp · May 30, 2023 · 4c78224 · 4c78224
1 parent 22e97d1
commit 4c78224
Show file tree

Hide file tree

Showing 35 changed files with 7 additions and 964 deletions.
diff --git a/config/set/privatization.php b/config/set/privatization.php
@@ -7,14 +7,14 @@
 use Rector\Privatization\Rector\Class_\FinalizeClassesWithoutChildrenRector;
 use Rector\Privatization\Rector\ClassMethod\PrivatizeFinalClassMethodRector;
 use Rector\Privatization\Rector\MethodCall\PrivatizeLocalGetterToPropertyRector;
-use Rector\Privatization\Rector\Property\ChangeReadOnlyPropertyWithDefaultValueToConstantRector;
 use Rector\Privatization\Rector\Property\PrivatizeFinalClassPropertyRector;
 
 return static function (RectorConfig $rectorConfig): void {
-    $rectorConfig->rule(FinalizeClassesWithoutChildrenRector::class);
-    $rectorConfig->rule(ChangeGlobalVariablesToPropertiesRector::class);
-    $rectorConfig->rule(ChangeReadOnlyPropertyWithDefaultValueToConstantRector::class);
-    $rectorConfig->rule(PrivatizeLocalGetterToPropertyRector::class);
-    $rectorConfig->rule(PrivatizeFinalClassPropertyRector::class);
-    $rectorConfig->rule(PrivatizeFinalClassMethodRector::class);
+    $rectorConfig->rules([
+        FinalizeClassesWithoutChildrenRector::class,
+        ChangeGlobalVariablesToPropertiesRector::class,
+        PrivatizeLocalGetterToPropertyRector::class,
+        PrivatizeFinalClassPropertyRector::class,
+        PrivatizeFinalClassMethodRector::class,
+    ]);
 };
diff --git a/...faultValueToConstantRector/ChangeReadOnlyPropertyWithDefaultValueToConstantRectorTest.php b/...faultValueToConstantRector/ChangeReadOnlyPropertyWithDefaultValueToConstantRectorTest.php
diff --git a/...ngeReadOnlyPropertyWithDefaultValueToConstantRector/Fixture/do_not_remove_comment.php.inc b/...ngeReadOnlyPropertyWithDefaultValueToConstantRector/Fixture/do_not_remove_comment.php.inc
diff --git a/...r/Property/ChangeReadOnlyPropertyWithDefaultValueToConstantRector/Fixture/fixture.php.inc b/...r/Property/ChangeReadOnlyPropertyWithDefaultValueToConstantRector/Fixture/fixture.php.inc
diff --git a/...ngeReadOnlyPropertyWithDefaultValueToConstantRector/Fixture/skip_assigned_in_ctor.php.inc b/...ngeReadOnlyPropertyWithDefaultValueToConstantRector/Fixture/skip_assigned_in_ctor.php.inc
diff --git a/...rty/ChangeReadOnlyPropertyWithDefaultValueToConstantRector/Fixture/skip_attribute.php.inc b/...rty/ChangeReadOnlyPropertyWithDefaultValueToConstantRector/Fixture/skip_attribute.php.inc
diff --git a/.../ChangeReadOnlyPropertyWithDefaultValueToConstantRector/Fixture/skip_end_function.php.inc b/.../ChangeReadOnlyPropertyWithDefaultValueToConstantRector/Fixture/skip_end_function.php.inc
diff --git a/...ReadOnlyPropertyWithDefaultValueToConstantRector/Fixture/skip_multiple_properties.php.inc b/...ReadOnlyPropertyWithDefaultValueToConstantRector/Fixture/skip_multiple_properties.php.inc
diff --git a/...rty/ChangeReadOnlyPropertyWithDefaultValueToConstantRector/Fixture/skip_overriden.php.inc b/...rty/ChangeReadOnlyPropertyWithDefaultValueToConstantRector/Fixture/skip_overriden.php.inc
diff --git a/...ty/ChangeReadOnlyPropertyWithDefaultValueToConstantRector/Fixture/skip_referenced.php.inc b/...ty/ChangeReadOnlyPropertyWithDefaultValueToConstantRector/Fixture/skip_referenced.php.inc
diff --git a/...y/ChangeReadOnlyPropertyWithDefaultValueToConstantRector/Fixture/skip_referenced2.php.inc b/...y/ChangeReadOnlyPropertyWithDefaultValueToConstantRector/Fixture/skip_referenced2.php.inc
diff --git a/...ltValueToConstantRector/Fixture/skip_referenced_in_method_call_with_another_class.php.inc b/...ltValueToConstantRector/Fixture/skip_referenced_in_method_call_with_another_class.php.inc
diff --git a/...lyPropertyWithDefaultValueToConstantRector/Fixture/skip_referenced_in_static_call.php.inc b/...lyPropertyWithDefaultValueToConstantRector/Fixture/skip_referenced_in_static_call.php.inc
diff --git a/...ltValueToConstantRector/Fixture/skip_referenced_in_static_call_with_another_class.php.inc b/...ltValueToConstantRector/Fixture/skip_referenced_in_static_call_with_another_class.php.inc
diff --git a/...roperty/ChangeReadOnlyPropertyWithDefaultValueToConstantRector/Fixture/skip_sniff.php.inc b/...roperty/ChangeReadOnlyPropertyWithDefaultValueToConstantRector/Fixture/skip_sniff.php.inc
diff --git a/...roperty/ChangeReadOnlyPropertyWithDefaultValueToConstantRector/Fixture/skip_trait.php.inc b/...roperty/ChangeReadOnlyPropertyWithDefaultValueToConstantRector/Fixture/skip_trait.php.inc
diff --git a/...ertyWithDefaultValueToConstantRector/Fixture/skip_unsetted_parent_array_dim_fetch.php.inc b/...ertyWithDefaultValueToConstantRector/Fixture/skip_unsetted_parent_array_dim_fetch.php.inc
diff --git a/...OnlyPropertyWithDefaultValueToConstantRector/Fixture/skip_unsetted_property_fetch.php.inc b/...OnlyPropertyWithDefaultValueToConstantRector/Fixture/skip_unsetted_property_fetch.php.inc