[Privatization] Skip Entity and Embeddable Attribute Doctrine\ORM\Map…

…ping on FinalizeClassesWithoutChildrenRector (#155)

Co-authored-by: Sebastian Schreiber <me@schreibersebastian.de>
Co-authored-by: Tomas Votruba <tomas.vot@gmail.com>

rules-tests/Privatization/Rector/Class_/FinalizeClassesWithoutChildrenRector/Fixture/skip_embeddable_with_attribute.php.inc

@@ -0,0 +1,11 @@
+<?php
+
+namespace Rector\Tests\Privatization\Rector\Class_\FinalizeClassesWithoutChildrenRector\Fixture;
+
+use Doctrine\ORM\Mapping\Embeddable;
+
+#[Embeddable]
+class People
+{
+
+}

rules-tests/Privatization/Rector/Class_/FinalizeClassesWithoutChildrenRector/Fixture/skip_entity_with_attribute.php.inc

@@ -0,0 +1,11 @@
+<?php
+
+namespace Rector\Tests\Privatization\Rector\Class_\FinalizeClassesWithoutChildrenRector\Fixture;
+
+use Doctrine\ORM\Mapping\Entity;
+
+#[Entity]
+class People
+{
+
+}

rules/Privatization/Rector/Class_/FinalizeClassesWithoutChildrenRector.php

@@ -5,6 +5,7 @@
 namespace Rector\Privatization\Rector\Class_;
 
 use PhpParser\Node;
+use PhpParser\Node\Name\FullyQualified;
 use PhpParser\Node\Stmt\Class_;
 use Rector\Core\NodeAnalyzer\ClassAnalyzer;
 use Rector\Core\Rector\AbstractRector;
@@ -16,6 +17,14 @@
  */
 final class FinalizeClassesWithoutChildrenRector extends AbstractRector
 {
+    /**
+     * @var string[]
+     */
+    private const DOCTRINE_ORM_MAPPING_ANNOTATION = [
+        'Doctrine\ORM\Mapping\Entity',
+        'Doctrine\ORM\Mapping\Embeddable',
+    ];
+
     public function __construct(
         private ClassAnalyzer $classAnalyzer
     ) {
@@ -82,16 +91,38 @@ public function refactor(Node $node): ?Node
         }
 
         $phpDocInfo = $this->phpDocInfoFactory->createFromNodeOrEmpty($node);
-        if ($phpDocInfo->hasByAnnotationClasses(['Doctrine\ORM\Mapping\Entity', 'Doctrine\ORM\Mapping\Embeddable'])) {
+        if ($phpDocInfo->hasByAnnotationClasses(self::DOCTRINE_ORM_MAPPING_ANNOTATION)) {
             return null;
         }
 
         if ($this->nodeRepository->hasClassChildren($node)) {
             return null;
         }
 
+        if ($this->hasEntityOrEmbeddableAttr($node)) {
+            return null;
+        }
+
         $this->visibilityManipulator->makeFinal($node);
 
         return $node;
     }
+
+    private function hasEntityOrEmbeddableAttr(Class_ $class): bool
+    {
+        foreach ($class->attrGroups as $attrGroup) {
+            foreach ($attrGroup->attrs as $attribute) {
+                if (! $attribute->name instanceof FullyQualified) {
+                    continue;
+                }
+
+                $className = $this->nodeNameResolver->getName($attribute->name);
+                if (in_array($className, self::DOCTRINE_ORM_MAPPING_ANNOTATION, true)) {
+                    return true;
+                }
+            }
+        }
+
+        return false;
+    }
 }

src/Console/Output/ShowOutputFormatterCollector.php

@@ -1,10 +1,9 @@
 <?php
-declare(strict_types=1);
 
+declare(strict_types=1);
 
 namespace Rector\Core\Console\Output;
 
-
 use Rector\ListReporting\Contract\Output\ShowOutputFormatterInterface;
 use Symfony\Component\Config\Definition\Exception\InvalidConfigurationException;
 
@@ -33,7 +32,7 @@ public function getByName(string $name): ShowOutputFormatterInterface
     }
 
     /**
-     * @return string[]
+     * @return int[]|string[]
      */
     public function getNames(): array
     {