Copy tests from symplify/autowire-array-parameter (#3152)

phpstan.neon

@@ -386,7 +386,7 @@ parameters:
         - '#Callable callable\(PHPStan\\Type\\Type\)\: PHPStan\\Type\\Type invoked with 2 parameters, 1 required#'
 
         # PHPStan 1.4.7
-        - '#Call to static method Webmozart\\Assert\\Assert\:\:allIsAOf|isAOf\(\) with .* will always evaluate to true#'
+        - '#Call to static method Webmozart\\Assert\\Assert\:\:allIsAOf|isAOf|assertInstanceOf\(\) with .* will always evaluate to true#'
 
         -
             message: '#Make callable type explicit#'

rules/Php80/Rector/FunctionLike/MixedTypeRector.php

@@ -90,12 +90,15 @@ public function refactor(Node $node): ?Node
 
         $this->refactorParamTypes($node, $phpDocInfo);
         $hasChanged = $this->paramTagRemover->removeParamTagsIfUseless($phpDocInfo, $node);
+        if ($this->hasChanged) {
+            return $node;
+        }
 
-        if (! $this->hasChanged && ! $hasChanged) {
-            return null;
+        if ($hasChanged) {
+            return $node;
         }
 
-        return $node;
+        return null;
     }
 
     public function provideMinPhpVersion(): int

src/DependencyInjection/CompilerPass/AutowireArrayParameterCompilerPass.php

@@ -19,6 +19,7 @@
 
 /**
  * @inspiration https://github.com/nette/di/pull/178
+ * @see \Rector\Core\Tests\DependencyInjection\CompilerPass\AutowireArrayParameterCompilerPassTest
  */
 final class AutowireArrayParameterCompilerPass implements CompilerPassInterface
 {

src/DependencyInjection/DefinitionFinder.php

@@ -11,6 +11,7 @@
 
 /**
  * @api
+ * @see \Rector\Core\Tests\DependencyInjection\DefinitionFinderTest
  */
 final class DefinitionFinder
 {

tests/DependencyInjection/CompilerPass/AutowireArrayParameterCompilerPassTest.php

@@ -0,0 +1,53 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\Core\Tests\DependencyInjection\CompilerPass;
+
+use Rector\Core\Tests\DependencyInjection\CompilerPass\Source\ArrayShapeCollector;
+use Rector\Core\Tests\DependencyInjection\CompilerPass\Source\Contract\FirstCollectedInterface;
+use Rector\Core\Tests\DependencyInjection\CompilerPass\Source\Contract\SecondCollectedInterface;
+use Rector\Core\Tests\DependencyInjection\CompilerPass\Source\IterableCollector;
+use Rector\Core\Tests\DependencyInjection\CompilerPass\Source\SomeCollector;
+use Rector\Core\Tests\DependencyInjection\HttpKernel\AutowireArrayParameterHttpKernel;
+use Symplify\PackageBuilder\Testing\AbstractKernelTestCase;
+
+final class AutowireArrayParameterCompilerPassTest extends AbstractKernelTestCase
+{
+    protected function setUp(): void
+    {
+        $this->bootKernel(AutowireArrayParameterHttpKernel::class);
+    }
+
+    public function test(): void
+    {
+        /** @var SomeCollector $someCollector */
+        $someCollector = $this->getService(SomeCollector::class);
+        $this->assertCount(3, $someCollector->getFirstCollected());
+        $this->assertCount(2, $someCollector->getSecondCollected());
+
+        $this->assertInstanceOf(FirstCollectedInterface::class, $someCollector->getFirstCollected()[0]);
+        $this->assertInstanceOf(SecondCollectedInterface::class, $someCollector->getSecondCollected()[0]);
+    }
+
+    public function testArrayShape(): void
+    {
+        $arrayShapeCollector = $this->getService(ArrayShapeCollector::class);
+        $this->assertCount(3, $arrayShapeCollector->getFirstCollected());
+        $this->assertCount(2, $arrayShapeCollector->getSecondCollected());
+
+        $this->assertInstanceOf(FirstCollectedInterface::class, $arrayShapeCollector->getFirstCollected()[0]);
+        $this->assertInstanceOf(SecondCollectedInterface::class, $arrayShapeCollector->getSecondCollected()[0]);
+    }
+
+    public function testIterable(): void
+    {
+        $iterableCollector = $this->getService(IterableCollector::class);
+
+        $this->assertCount(3, $iterableCollector->getFirstCollected());
+        $this->assertCount(2, $iterableCollector->getSecondCollected());
+
+        $this->assertInstanceOf(FirstCollectedInterface::class, $iterableCollector->getFirstCollected()[0]);
+        $this->assertInstanceOf(SecondCollectedInterface::class, $iterableCollector->getSecondCollected()[0]);
+    }
+}

tests/DependencyInjection/CompilerPass/Source/ArrayShapeCollector.php

@@ -0,0 +1,48 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\Core\Tests\DependencyInjection\CompilerPass\Source;
+
+use Rector\Core\Tests\DependencyInjection\CompilerPass\Source\Contract\FirstCollectedInterface;
+use Rector\Core\Tests\DependencyInjection\CompilerPass\Source\Contract\SecondCollectedInterface;
+
+final class ArrayShapeCollector
+{
+    /**
+     * @var array<FirstCollectedInterface>
+     */
+    private $firstCollected = [];
+
+    /**
+     * @var array<SecondCollectedInterface>
+     */
+    private $secondCollected = [];
+
+    /**
+     * @param array<FirstCollectedInterface> $firstCollected
+     * @param array<SecondCollectedInterface> $secondCollected
+     */
+    public function __construct(array $firstCollected, array $secondCollected)
+    {
+        $this->firstCollected = $firstCollected;
+        $this->secondCollected = $secondCollected;
+    }
+
+    /**
+     * @return array<FirstCollectedInterface>
+     */
+    public function getFirstCollected(): array
+    {
+        return $this->firstCollected;
+    }
+
+    /**
+     * @return array<SecondCollectedInterface>
+     */
+    public function getSecondCollected(): array
+    {
+        return $this->secondCollected;
+    }
+
+}

tests/DependencyInjection/CompilerPass/Source/Collected/FirstServiceOfFirstCollected.php

@@ -0,0 +1,12 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\Core\Tests\DependencyInjection\CompilerPass\Source\Collected;
+
+use Rector\Core\Tests\DependencyInjection\CompilerPass\Source\Contract\FirstCollectedInterface;
+
+final class FirstServiceOfFirstCollected implements FirstCollectedInterface
+{
+
+}

tests/DependencyInjection/CompilerPass/Source/Collected/FirstServiceOfSecondCollected.php

@@ -0,0 +1,12 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\Core\Tests\DependencyInjection\CompilerPass\Source\Collected;
+
+use Rector\Core\Tests\DependencyInjection\CompilerPass\Source\Contract\SecondCollectedInterface;
+
+final class FirstServiceOfSecondCollected implements SecondCollectedInterface
+{
+
+}

tests/DependencyInjection/CompilerPass/Source/Collected/SecondServiceOfFirstCollected.php

@@ -0,0 +1,12 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\Core\Tests\DependencyInjection\CompilerPass\Source\Collected;
+
+use Rector\Core\Tests\DependencyInjection\CompilerPass\Source\Contract\FirstCollectedInterface;
+
+final class SecondServiceOfFirstCollected implements FirstCollectedInterface
+{
+
+}

tests/DependencyInjection/CompilerPass/Source/Collected/SecondServiceOfSecondCollected.php

@@ -0,0 +1,12 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\Core\Tests\DependencyInjection\CompilerPass\Source\Collected;
+
+use Rector\Core\Tests\DependencyInjection\CompilerPass\Source\Contract\SecondCollectedInterface;
+
+final class SecondServiceOfSecondCollected implements SecondCollectedInterface
+{
+
+}

tests/DependencyInjection/CompilerPass/Source/Collected/SomeCollectedPromoted.php

@@ -0,0 +1,11 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\Core\Tests\DependencyInjection\CompilerPass\Source\Collected;
+
+use Rector\Core\Tests\DependencyInjection\CompilerPass\Source\Contract\FirstCollectedInterface;
+
+final class SomeCollectedPromoted implements FirstCollectedInterface
+{
+}

tests/DependencyInjection/CompilerPass/Source/Contract/FirstCollectedInterface.php

@@ -0,0 +1,10 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\Core\Tests\DependencyInjection\CompilerPass\Source\Contract;
+
+interface FirstCollectedInterface
+{
+
+}

tests/DependencyInjection/CompilerPass/Source/Contract/SecondCollectedInterface.php

@@ -0,0 +1,10 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\Core\Tests\DependencyInjection\CompilerPass\Source\Contract;
+
+interface SecondCollectedInterface
+{
+
+}

tests/DependencyInjection/CompilerPass/Source/IterableCollector.php

@@ -0,0 +1,47 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\Core\Tests\DependencyInjection\CompilerPass\Source;
+
+use Rector\Core\Tests\DependencyInjection\CompilerPass\Source\Contract\FirstCollectedInterface;
+use Rector\Core\Tests\DependencyInjection\CompilerPass\Source\Contract\SecondCollectedInterface;
+
+final class IterableCollector
+{
+    /**
+     * @var iterable<FirstCollectedInterface>
+     */
+    private $firstCollected = [];
+
+    /**
+     * @var iterable<SecondCollectedInterface>
+     */
+    private $secondCollected = [];
+
+    /**
+     * @param iterable<FirstCollectedInterface> $firstCollected
+     * @param iterable<SecondCollectedInterface> $secondCollected
+     */
+    public function __construct(array $firstCollected, array $secondCollected)
+    {
+        $this->firstCollected = $firstCollected;
+        $this->secondCollected = $secondCollected;
+    }
+
+    /**
+     * @return iterable<FirstCollectedInterface>
+     */
+    public function getFirstCollected(): array
+    {
+        return $this->firstCollected;
+    }
+
+    /**
+     * @return iterable<SecondCollectedInterface>
+     */
+    public function getSecondCollected(): array
+    {
+        return $this->secondCollected;
+    }
+}

tests/DependencyInjection/CompilerPass/Source/PromotedPropertyCollector.php

@@ -0,0 +1,26 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\Core\Tests\DependencyInjection\CompilerPass\Source;
+
+use Rector\Core\Tests\DependencyInjection\CompilerPass\Source\Contract\FirstCollectedInterface;
+
+final class PromotedPropertyCollector
+{
+    /**
+     * @param FirstCollectedInterface[] $firstCollected
+     */
+    public function __construct(
+        private array $firstCollected
+    ) {
+    }
+
+    /**
+     * @return FirstCollectedInterface[]
+     */
+    public function getFirstCollected(): array
+    {
+        return $this->firstCollected;
+    }
+}

tests/DependencyInjection/CompilerPass/Source/SkipMe/SkipUnionTypes.php

@@ -0,0 +1,16 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\Core\Tests\DependencyInjection\CompilerPass\Source\SkipMe;
+
+use Rector\Core\Tests\DependencyInjection\CompilerPass\Source\Contract\FirstCollectedInterface;
+use Rector\Core\Tests\DependencyInjection\CompilerPass\Source\Contract\SecondCollectedInterface;
+
+final class SkipUnionTypes
+{
+    public function __construct(
+        public FirstCollectedInterface|SecondCollectedInterface $collectedInterface
+    ) {
+    }
+}

tests/DependencyInjection/CompilerPass/Source/SomeCollector.php

@@ -0,0 +1,47 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\Core\Tests\DependencyInjection\CompilerPass\Source;
+
+use Rector\Core\Tests\DependencyInjection\CompilerPass\Source\Contract\FirstCollectedInterface;
+use Rector\Core\Tests\DependencyInjection\CompilerPass\Source\Contract\SecondCollectedInterface;
+
+final class SomeCollector
+{
+    /**
+     * @var FirstCollectedInterface[]
+     */
+    private $firstCollected = [];
+
+    /**
+     * @var SecondCollectedInterface[]
+     */
+    private $secondCollected = [];
+
+    /**
+     * @param FirstCollectedInterface[] $firstCollected
+     * @param SecondCollectedInterface[] $secondCollected
+     */
+    public function __construct(array $firstCollected, array $secondCollected)
+    {
+        $this->firstCollected = $firstCollected;
+        $this->secondCollected = $secondCollected;
+    }
+
+    /**
+     * @return FirstCollectedInterface[]
+     */
+    public function getFirstCollected(): array
+    {
+        return $this->firstCollected;
+    }
+
+    /**
+     * @return SecondCollectedInterface[]
+     */
+    public function getSecondCollected(): array
+    {
+        return $this->secondCollected;
+    }
+}