static fixes

rectorphp · Dec 4, 2022 · 58069c3 · 58069c3
1 parent 3dea2bd
commit 58069c3
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 4 deletions.
diff --git a/phpstan.neon b/phpstan.neon
@@ -608,6 +608,7 @@ parameters:
             message: '#Method call return value that should be used, but is not#'
             paths:
                 - src/Console/Output/RectorOutputStyle.php
+                - rules/Compatibility/NodeFactory/ConstructorClassMethodFactory.php
                 - src/Application/ChangedNodeScopeRefresher.php
                 - rules/TypeDeclaration/TypeNormalizer.php
                 - rules/TypeDeclaration/Rector/ClassMethod/ReturnTypeFromStrictNewArrayRector.php

diff --git a/rules/Php80/Rector/FunctionLike/MixedTypeRector.php b/rules/Php80/Rector/FunctionLike/MixedTypeRector.php
@@ -89,9 +89,9 @@ public function refactor(Node $node): ?Node
         $phpDocInfo = $this->phpDocInfoFactory->createFromNodeOrEmpty($node);
 
         $this->refactorParamTypes($node, $phpDocInfo);
-        $this->paramTagRemover->removeParamTagsIfUseless($phpDocInfo, $node);
+        $hasChanged = $this->paramTagRemover->removeParamTagsIfUseless($phpDocInfo, $node);
 
-        if (! $this->hasChanged) {
+        if (! $this->hasChanged && ! $hasChanged) {
             return null;
         }
 

diff --git a/rules/Php80/Rector/FunctionLike/UnionTypesRector.php b/rules/Php80/Rector/FunctionLike/UnionTypesRector.php
@@ -105,8 +105,8 @@ public function refactor(Node $node): ?Node
         $this->refactorParamTypes($node, $phpDocInfo);
         $this->refactorReturnType($node, $phpDocInfo);
 
-        $this->paramTagRemover->removeParamTagsIfUseless($phpDocInfo, $node);
-        if ($phpDocInfo->hasChanged()) {
+        $hasChanged = $this->paramTagRemover->removeParamTagsIfUseless($phpDocInfo, $node);
+        if ($hasChanged) {
             $this->hasChanged = true;
         }