[Performance] Avoid ReflectionProvider check function exists on NameI…

…mportingPostRector (#5083) * [Performance] Remove ReflectionProvider check function exists on NameImportingPostRector * [ci-review] Rector Rectify --------- Co-authored-by: GitHub Action <actions@github.com>
rectorphp · Sep 26, 2023 · 50eb9ef · 50eb9ef
1 parent 50e589c
commit 50eb9ef
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 8 deletions.
diff --git a/packages/BetterPhpDocParser/PhpDoc/ArrayItemNode.php b/packages/BetterPhpDocParser/PhpDoc/ArrayItemNode.php
@@ -31,7 +31,7 @@ public function __toString(): string
                 $value .= $singleValue;
             }
         } elseif ($this->value instanceof DoctrineAnnotationTagValueNode) {
-            $value .= (string) $this->value->identifierTypeNode . $this->value;
+            $value .= $this->value->identifierTypeNode . $this->value;
         } else {
             $value .= $this->value;
         }

diff --git a/packages/PostRector/Rector/NameImportingPostRector.php b/packages/PostRector/Rector/NameImportingPostRector.php
@@ -14,7 +14,6 @@
 use PhpParser\Node\Stmt\InlineHTML;
 use PhpParser\Node\Stmt\Namespace_;
 use PhpParser\Node\Stmt\Use_;
-use PHPStan\Reflection\ReflectionProvider;
 use Rector\BetterPhpDocParser\PhpDocInfo\PhpDocInfo;
 use Rector\BetterPhpDocParser\PhpDocInfo\PhpDocInfoFactory;
 use Rector\CodingStyle\ClassNameImport\ClassNameImportSkipper;
@@ -37,7 +36,6 @@ public function __construct(
         private readonly DocBlockNameImporter $docBlockNameImporter,
         private readonly ClassNameImportSkipper $classNameImportSkipper,
         private readonly PhpDocInfoFactory $phpDocInfoFactory,
-        private readonly ReflectionProvider $reflectionProvider,
         private readonly CurrentFileProvider $currentFileProvider,
         private readonly UseImportsResolver $useImportsResolver,
         private readonly AliasNameResolver $aliasNameResolver,
@@ -208,10 +206,6 @@ private function shouldImportName(Name $name, array $currentUses): bool
             return true;
         }
 
-        if ($this->classNameImportSkipper->isAlreadyImported($name, $currentUses)) {
-            return true;
-        }
-
-        return $this->reflectionProvider->hasFunction(new Name($name->getLast()), null);
+        return $this->classNameImportSkipper->isAlreadyImported($name, $currentUses);
     }
 }