Skip to content

[Performance] Avoid ReflectionProvider check function exists on NameImportingPostRector#5083

Merged
samsonasik merged 2 commits intomainfrom
performance-auto-import
Sep 26, 2023
Merged

[Performance] Avoid ReflectionProvider check function exists on NameImportingPostRector#5083
samsonasik merged 2 commits intomainfrom
performance-auto-import

Conversation

@samsonasik
Copy link
Copy Markdown
Member

While I was trying to fix conflict defined function to fqcn function at PR:

the ReflectionProvider check function is not needed, it seems for native function, checked at

if ($name->getAttribute(AttributeKey::IS_FUNCCALL_NAME) === true) {
return count($name->getParts()) === 1;
}

@samsonasik
Copy link
Copy Markdown
Member Author

All checks have passed 🎉 @TomasVotruba I am merging it ;)

@samsonasik samsonasik merged commit 50eb9ef into main Sep 26, 2023
@samsonasik samsonasik deleted the performance-auto-import branch September 26, 2023 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants