fixup! [PHP 8.2] Add rule for AllowDynamicProperties attribute (#1225)

packages/NodeTypeResolver/Node/AttributeKey.php

@@ -215,4 +215,8 @@ final class AttributeKey
      * @var string
      */
     public const STATEMENT_DEPTH = 'statementDepth';
+    /**
+     * @var string
+     */
+    public const HAS_NEW_INHERITED_TYPE = 'has_new_inherited_type';
 }

rules-tests/TypeDeclaration/Rector/Property/AddPropertyTypeDeclarationRector/AddPropertyTypeDeclarationRectorTest.php

@@ -0,0 +1,31 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\Tests\TypeDeclaration\Rector\Property\AddPropertyTypeDeclarationRector;
+
+use Rector\Testing\PHPUnit\AbstractRectorTestCase;
+
+final class AddPropertyTypeDeclarationRectorTest extends AbstractRectorTestCase
+{
+    /**
+     * @dataProvider provideData()
+     */
+    public function test(\Symplify\SmartFileSystem\SmartFileInfo $fileInfo): void
+    {
+        $this->doTestFileInfo($fileInfo);
+    }
+
+    /**
+     * @return \Iterator<\Symplify\SmartFileSystem\SmartFileInfo>
+     */
+    public function provideData(): \Iterator
+    {
+        return $this->yieldFilesFromDirectory(__DIR__ . '/Fixture');
+    }
+
+    public function provideConfigFilePath(): string
+    {
+        return __DIR__ . '/config/configured_rule.php';
+    }
+}

rules-tests/TypeDeclaration/Rector/Property/AddPropertyTypeDeclarationRector/Fixture/some_class.php.inc

@@ -0,0 +1,21 @@
+<?php
+
+namespace Rector\Tests\TypeDeclaration\Rector\Property\AddPropertyTypeDeclarationRector\Fixture;
+
+class SomeClass extends ParentClass
+{
+    public $name;
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Tests\TypeDeclaration\Rector\Property\AddPropertyTypeDeclarationRector\Fixture;
+
+class SomeClass extends ParentClass
+{
+    public string $name;
+}
+
+?>

rules-tests/TypeDeclaration/Rector/Property/AddPropertyTypeDeclarationRector/config/configured_rule.php

@@ -0,0 +1,10 @@
+<?php
+
+declare(strict_types=1);
+
+use Symfony\Component\DependencyInjection\Loader\Configurator\ContainerConfigurator;
+
+return static function (ContainerConfigurator $containerConfigurator): void {
+    $services = $containerConfigurator->services();
+    $services->set(\Rector\TypeDeclaration\Rector\Property\AddPropertyTypeDeclarationRector::class);
+};

rules/TypeDeclaration/Rector/FunctionLike/ParamTypeDeclarationRector.php

@@ -208,6 +208,6 @@ private function shouldSkipParam(Param $param, ClassMethod | Function_ $function
         }
 
         // already set → skip
-        return ! $param->type->getAttribute(NewType::HAS_NEW_INHERITED_TYPE, false);
+        return ! $param->type->getAttribute(AttributeKey::HAS_NEW_INHERITED_TYPE, false);
     }
 }

rules/TypeDeclaration/Rector/Property/AddPropertyTypeDeclarationRector.php

@@ -0,0 +1,68 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\TypeDeclaration\Rector\Property;
+
+use PhpParser\Node;
+use Rector\Core\Contract\Rector\ConfigurableRectorInterface;
+use Rector\Core\Rector\AbstractRector;
+use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
+use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
+
+/**
+
+ * @see \Rector\Tests\TypeDeclaration\Rector\Property\AddPropertyTypeDeclarationRector\AddPropertyTypeDeclarationRectorTest
+ */
+final class AddPropertyTypeDeclarationRector extends AbstractRector implements ConfigurableRectorInterface
+{
+    public function getRuleDefinition(): RuleDefinition
+    {
+        return new RuleDefinition('Add type to property by added rules, mostly public/property by parent type', [
+            new CodeSample(
+                <<<'CODE_SAMPLE'
+class SomeClass extends ParentClass
+{
+    public $name;
+}
+CODE_SAMPLE
+
+                ,
+                <<<'CODE_SAMPLE'
+class SomeClass extends ParentClass
+{
+    public string $name;
+}
+CODE_SAMPLE
+
+            )
+        ]);
+    }
+
+    /**
+     * @return array<class-string<\PhpParser\Node>>
+     */
+    public function getNodeTypes(): array
+    {
+        return array(\PhpParser\Node\Stmt\Property::class);
+    }
+
+    /**
+     * @param \PhpParser\Node\Stmt\Property $node
+     */
+    public function refactor(Node $node): ?Node
+    {
+        // change the node
+
+        return $node;
+    }
+
+    /**
+     * @param array<string $configuration
+     * @return void
+     */
+    public function configure(array $configuration): void
+    {
+        // TODO: Implement configure() method.
+    }
+}

rules/TypeDeclaration/ValueObject/AddPropertyType.php

@@ -0,0 +1,32 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\TypeDeclaration\ValueObject;
+
+use PHPStan\Type\Type;
+
+final class AddPropertyType
+{
+    public function __construct(
+        private string $class,
+        private string $propertyName,
+        private Type $type
+    ) {
+    }
+
+    public function getClass(): string
+    {
+        return $this->class;
+    }
+
+    public function getPropertyName(): string
+    {
+        return $this->propertyName;
+    }
+
+    public function getType(): Type
+    {
+        return $this->type;
+    }
+}