InlineConstructorDefaultToPropertyRector Readonly Class (#5085)

rectorphp · Sep 27, 2023 · 5fb68b4 · 5fb68b4
1 parent 1a65049
commit 5fb68b4
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 1 deletion.
diff --git a/...ss_/InlineConstructorDefaultToPropertyRector/Fixture/do_not_change_readonly_class.php.inc b/...ss_/InlineConstructorDefaultToPropertyRector/Fixture/do_not_change_readonly_class.php.inc
@@ -0,0 +1,13 @@
+<?php
+
+namespace Rector\Tests\CodeQuality\Rector\Class_\InlineConstructorDefaultToPropertyRector\Fixture;
+
+readonly class DoNotChangeReadonlyClass
+{
+    private string $name;
+
+    public function __construct()
+    {
+        $this->name = 'John';
+    }
+}
diff --git a/rules/CodeQuality/Rector/Class_/InlineConstructorDefaultToPropertyRector.php b/rules/CodeQuality/Rector/Class_/InlineConstructorDefaultToPropertyRector.php
@@ -162,7 +162,7 @@ private function refactorProperty(
             }
 
             // readonly property cannot have default value
-            if ($classStmt->isReadonly()) {
+            if ($classStmt->isReadonly() || $class->isReadonly()) {
                 continue;
             }