InlineConstructorDefaultToPropertyRector Readonly Class#5085
Merged
TomasVotruba merged 2 commits intorectorphp:mainfrom Sep 27, 2023
Merged
InlineConstructorDefaultToPropertyRector Readonly Class#5085TomasVotruba merged 2 commits intorectorphp:mainfrom
TomasVotruba merged 2 commits intorectorphp:mainfrom
Conversation
Contributor
|
could you add a unit test for the case you are talking about? |
Contributor
Author
|
@staabm Added |
Member
|
Looks good 👍 Thank you |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PHP Parser does not mark properties as readonly when the class itself is readonly. Therefor we also need to check the class if it's readonly.
This feels like a bug in PHP-Parser though, so I've also opened an issue there. nikic/PHP-Parser#949