move collectors to src/Collector namespace for easy discovery, add Mo…

…ckedClassCollector (#5055)

rector.php

@@ -4,13 +4,16 @@
 
 use Rector\CodingStyle\Rector\String_\UseClassKeywordForClassNameResolutionRector;
 use Rector\Config\RectorConfig;
+
+use Rector\Core\Collector\MockedClassCollector;
+use Rector\Core\Collector\ParentClassCollector;
+use Rector\DeadCode\Rector\ClassMethod\RemoveEmptyClassMethodRector;
 use Rector\DeadCode\Rector\ConstFetch\RemovePhpVersionIdCheckRector;
 use Rector\Php55\Rector\String_\StringClassNameToClassConstantRector;
 use Rector\PHPUnit\Set\PHPUnitSetList;
 use Rector\Privatization\Rector\Class_\FinalizeClassesWithoutChildrenCollectorRector;
 use Rector\Set\ValueObject\LevelSetList;
 use Rector\Set\ValueObject\SetList;
-use Rector\TypeDeclaration\Collector\ParentClassCollector;
 use Rector\TypeDeclaration\Rector\ClassMethod\AddMethodCallBasedStrictParamTypeRector;
 use Rector\TypeDeclaration\Rector\StmtsAwareInterface\DeclareStrictTypesRector;
 use Rector\Utils\Rector\MoveAbstractRectorToChildrenRector;
@@ -33,6 +36,7 @@
 
     // testing collectors
     $rectorConfig->collector(ParentClassCollector::class);
+    $rectorConfig->collector(MockedClassCollector::class);
     $rectorConfig->rule(FinalizeClassesWithoutChildrenCollectorRector::class);
 
     $rectorConfig->rules([DeclareStrictTypesRector::class, MoveAbstractRectorToChildrenRector::class]);

rules-tests/Privatization/Rector/Class_/FinalizeClassesWithoutChildrenCollectorRector/config/configured_rule.php

@@ -3,8 +3,8 @@
 declare(strict_types=1);
 
 use Rector\Config\RectorConfig;
+use Rector\Core\Collector\ParentClassCollector;
 use Rector\Privatization\Rector\Class_\FinalizeClassesWithoutChildrenCollectorRector;
-use Rector\TypeDeclaration\Collector\ParentClassCollector;
 
 return static function (RectorConfig $rectorConfig): void {
     $rectorConfig->rule(FinalizeClassesWithoutChildrenCollectorRector::class);

rules/Privatization/Rector/Class_/FinalizeClassesWithoutChildrenCollectorRector.php

@@ -9,13 +9,13 @@
 use PhpParser\Node\Stmt\Class_;
 use PHPStan\Node\CollectedDataNode;
 use PHPStan\Reflection\ClassReflection;
+use Rector\Core\Collector\ParentClassCollector;
 use Rector\Core\NodeAnalyzer\ClassAnalyzer;
 use Rector\Core\NodeAnalyzer\DoctrineEntityAnalyzer;
 use Rector\Core\Rector\AbstractCollectorRector;
 use Rector\Core\Reflection\ReflectionResolver;
 use Rector\NodeTypeResolver\Node\AttributeKey;
 use Rector\Privatization\NodeManipulator\VisibilityManipulator;
-use Rector\TypeDeclaration\Collector\ParentClassCollector;
 use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
 
 /**

rules/TypeDeclaration/Rector/ClassMethod/AddParamTypeBasedOnPHPUnitDataProviderRector.php

@@ -310,12 +310,12 @@ private function resolveDataProviderNodes(ClassMethod $classMethod): DataProvide
     /**
      * @return array<array-key, Attribute>
      */
-    private function getPhpDataProviderAttributes(ClassMethod $node): array
+    private function getPhpDataProviderAttributes(ClassMethod $classMethod): array
     {
         $attributeName = 'PHPUnit\Framework\Attributes\DataProvider';
 
         /** @var AttributeGroup[] $attrGroups */
-        $attrGroups = $node->attrGroups;
+        $attrGroups = $classMethod->attrGroups;
 
         $dataProviders = [];
 

src/Collector/MockedClassCollector.php

@@ -0,0 +1,53 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\Core\Collector;
+
+use PhpParser\Node;
+use PhpParser\Node\Arg;
+use PhpParser\Node\Expr\MethodCall;
+use PhpParser\Node\Identifier;
+use PHPStan\Analyser\Scope;
+use PHPStan\Collectors\Collector;
+use PHPStan\Type\Constant\ConstantStringType;
+
+/**
+ * @implements Collector<MethodCall, string[]|null>
+ */
+final class MockedClassCollector implements Collector
+{
+    public function getNodeType(): string
+    {
+        return MethodCall::class;
+    }
+
+    /**
+     * @param MethodCall $node
+     * @return string[]|null
+     */
+    public function processNode(Node $node, Scope $scope): ?array
+    {
+        if (! $node->name instanceof Identifier) {
+            return null;
+        }
+
+        $methodName = $node->name->toString();
+        if (! in_array($methodName, ['createMock', 'buildMock'], true)) {
+            return null;
+        }
+
+        $firstArg = $node->getArgs()[0] ?? null;
+        if (! $firstArg instanceof Arg) {
+            return null;
+        }
+
+        $mockedClassType = $scope->getType($firstArg->value);
+
+        if (! $mockedClassType instanceof ConstantStringType) {
+            return null;
+        }
+
+        return [$mockedClassType->getValue()];
+    }
+}

rules/TypeDeclaration/Collector/ParentClassCollector.php → src/Collector/ParentClassCollector.php

@@ -2,7 +2,7 @@
 
 declare(strict_types=1);
 
-namespace Rector\TypeDeclaration\Collector;
+namespace Rector\Core\Collector;
 
 use PhpParser\Node;
 use PhpParser\Node\Name;

src/DependencyInjection/LazyContainerFactory.php

@@ -49,6 +49,7 @@
 use Rector\Config\RectorConfig;
 use Rector\Core\Application\ChangedNodeScopeRefresher;
 use Rector\Core\Application\FileProcessor;
+use Rector\Core\Collector\ParentClassCollector;
 use Rector\Core\Configuration\ConfigInitializer;
 use Rector\Core\Configuration\RenamedClassesDataCollector;
 use Rector\Core\Console\Command\ListRulesCommand;
@@ -179,7 +180,6 @@
 use Rector\StaticTypeMapper\PhpParser\StringNodeMapper;
 use Rector\StaticTypeMapper\PhpParser\UnionTypeNodeMapper;
 use Rector\StaticTypeMapper\StaticTypeMapper;
-use Rector\TypeDeclaration\Collector\ParentClassCollector;
 use Rector\Utils\Command\MissingInSetCommand;
 use Rector\Utils\Command\OutsideAnySetCommand;
 use Symfony\Component\Console\Application;