remove unused matchesStringName()

rectorphp · Sep 9, 2023 · 6a88d44 · 6a88d44
1 parent 2397a71
commit 6a88d44
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 19 deletions.
diff --git a/packages/NodeNameResolver/NodeNameResolver.php b/packages/NodeNameResolver/NodeNameResolver.php
@@ -15,9 +15,7 @@
 use Rector\CodingStyle\Naming\ClassNaming;
 use Rector\Core\Exception\ShouldNotHappenException;
 use Rector\Core\NodeAnalyzer\CallAnalyzer;
-use Rector\Core\Util\StringUtils;
 use Rector\NodeNameResolver\Contract\NodeNameResolverInterface;
-use Rector\NodeNameResolver\Regex\RegexPatternDetector;
 use Rector\NodeTypeResolver\Node\AttributeKey;
 
 final class NodeNameResolver
@@ -221,21 +219,6 @@ public function isStringName(string $resolvedName, string $desiredName): bool
         return strtolower($resolvedName) === strtolower($desiredName);
     }
 
-    public function matchesStringName(string|Identifier $resolvedName, string $desiredNamePattern): bool
-    {
-        if ($resolvedName instanceof Identifier) {
-            $resolvedName = $resolvedName->toString();
-        }
-
-        //        // is probably regex pattern
-        //        if ($this->regexPatternDetector->isRegexPattern($desiredNamePattern)) {
-        //            return StringUtils::isMatch($resolvedName, $desiredNamePattern);
-        //        }
-
-        // is probably fnmatch
-        return fnmatch($desiredNamePattern, $resolvedName, FNM_NOESCAPE);
-    }
-
     private function isCallOrIdentifier(Expr|Identifier $node): bool
     {
         if ($node instanceof Expr) {

diff --git a/rules/Php55/Rector/String_/StringClassNameToClassConstantRector.php b/rules/Php55/Rector/String_/StringClassNameToClassConstantRector.php
@@ -180,7 +180,7 @@ private function shouldSkip(string $classLikeName): bool
                 return true;
             }
 
-            if ($this->nodeNameResolver->matchesStringName($classLikeName, $classToSkip)) {
+            if (fnmatch($classToSkip, $classLikeName, FNM_NOESCAPE)) {
                 return true;
             }
         }

diff --git a/rules/Transform/Rector/Class_/AddAllowDynamicPropertiesAttributeRector.php b/rules/Transform/Rector/Class_/AddAllowDynamicPropertiesAttributeRector.php
@@ -146,7 +146,7 @@ private function shouldSkip(Class_ $class): bool
                     continue;
                 }
 
-                if (! $this->nodeNameResolver->matchesStringName($className, $transformOnNamespace)) {
+                if (! fnmatch($transformOnNamespace, $className, FNM_NOESCAPE)) {
                     return true;
                 }
             }