Improve NodeComparator performance (#3659)

rectorphp · Apr 22, 2023 · 731baeb · 731baeb
1 parent 81e7980
commit 731baeb
Showing 1 changed file with 8 additions and 9 deletions.
diff --git a/src/PhpParser/Comparing/NodeComparator.php b/src/PhpParser/Comparing/NodeComparator.php
@@ -35,28 +35,27 @@ public function printWithoutComments(Node | array | null $node): string
      */
     public function areNodesEqual(Node | array | null $firstNode, Node | array | null $secondNode): bool
     {
-        if ($firstNode instanceof Node && $secondNode === null) {
+        if ($firstNode instanceof Node && !$secondNode instanceof Node) {
             return false;
         }
-
-        if ($secondNode instanceof Node && $firstNode === null) {
+        if (!$firstNode instanceof Node && $secondNode instanceof Node) {
             return false;
         }
 
         if (is_array($firstNode)) {
-            Assert::allIsAOf($firstNode, Node::class);
-
-            if ($secondNode === null) {
+            if (!is_array($secondNode)) {
                 return false;
             }
+
+            Assert::allIsAOf($firstNode, Node::class);
         }
 
         if (is_array($secondNode)) {
-            Assert::allIsAOf($secondNode, Node::class);
-
-            if ($firstNode === null) {
+            if (!is_array($firstNode)) {
                 return false;
             }
+
+            Assert::allIsAOf($secondNode, Node::class);
         }
 
         return $this->printWithoutComments($firstNode) === $this->printWithoutComments($secondNode);