Remove auto import on changed files only to avoid too detailed setup …

…and making ambiguous code (#3132)
rectorphp · Nov 30, 2022 · 7a65218 · 7a65218
1 parent 7331d04
commit 7a65218
Show file tree

Hide file tree

Showing 7 changed files with 2 additions and 131 deletions.
diff --git a/build/target-repository/docs/auto_import_names.md b/build/target-repository/docs/auto_import_names.md
@@ -35,17 +35,6 @@ Do you want to keep those?
 $rectorConfig->importShortClasses(false);
 ```
 
-<br>
-
-If you have set `Option::AUTO_IMPORT_NAMES` to `true`, rector is applying this to every analyzed file, even if no real change by a rector was applied to the file.
-
-The reason is that a so-called post-rector is responsible for this, namely the `NameImportingPostRector`.
-If you like to apply the Option::AUTO_IMPORT_NAMES only for real changed files, you can configure this.
-
-```php
-$parameters->set(Option::APPLY_AUTO_IMPORT_NAMES_ON_CHANGED_FILES_ONLY, true);
-```
-
 ## How to Remove Unused Imports?
 
 To remove imports, use [ECS](https://github.com/symplify/easy-coding-standard) with [`NoUnusedImportsFixer`](https://github.com/FriendsOfPHP/PHP-CS-Fixer/blob/2.18/doc/rules/import/no_unused_imports.rst) rule:

diff --git a/packages/PostRector/Rector/NameImportingPostRector.php b/packages/PostRector/Rector/NameImportingPostRector.php
@@ -53,10 +53,6 @@ public function enterNode(Node $node): ?Node
             return null;
         }
 
-        if (! $this->shouldApply($file)) {
-            return null;
-        }
-
         if ($node instanceof Name) {
             return $this->processNodeName($node, $file);
         }
@@ -228,13 +224,4 @@ private function shouldImportName(Name $name, array $currentUses): bool
 
         return $this->reflectionProvider->hasFunction(new Name($name->getLast()), null);
     }
-
-    private function shouldApply(File $file): bool
-    {
-        if (! $this->parameterProvider->provideBoolParameter(Option::APPLY_AUTO_IMPORT_NAMES_ON_CHANGED_FILES_ONLY)) {
-            return true;
-        }
-
-        return $file->hasContentChanged();
-    }
 }
diff --git a/...ctor/Namespace_/ImportFullyQualifiedNamesRector/AutoImportNamesOnlyOnChangedFilesTest.php b/...ctor/Namespace_/ImportFullyQualifiedNamesRector/AutoImportNamesOnlyOnChangedFilesTest.php
diff --git a/...dNamesRector/FixtureNameImportingOnChangedFiles/auto_import_names_on_changed_file.php.inc b/...dNamesRector/FixtureNameImportingOnChangedFiles/auto_import_names_on_changed_file.php.inc
diff --git a/...edNamesRector/FixtureNameImportingOnChangedFiles/skip_auto_import_names_no_change.php.inc b/...edNamesRector/FixtureNameImportingOnChangedFiles/skip_auto_import_names_no_change.php.inc
diff --git a/...Namespace_/ImportFullyQualifiedNamesRector/config/import_only_on_changed_files_config.php b/...Namespace_/ImportFullyQualifiedNamesRector/config/import_only_on_changed_files_config.php
diff --git a/src/Configuration/Option.php b/src/Configuration/Option.php
@@ -170,6 +170,8 @@ final class Option
 
     /**
      * @var string
+     * @deprecated
+     * @api
      */
     public const APPLY_AUTO_IMPORT_NAMES_ON_CHANGED_FILES_ONLY = 'apply_auto_import_names_on_changed_files_only';