Skip traits in CountOnNullRector (#4556)

rectorphp · Jul 20, 2023 · 7b2f2e8 · 7b2f2e8
1 parent ebe8c2e
commit 7b2f2e8
Show file tree

Hide file tree

Showing 2 changed files with 26 additions and 0 deletions.
diff --git a/rules-tests/Php71/Rector/FuncCall/CountOnNullRector/Fixture/skip_trait.php.inc b/rules-tests/Php71/Rector/FuncCall/CountOnNullRector/Fixture/skip_trait.php.inc
@@ -0,0 +1,11 @@
+<?php
+
+namespace Rector\Tests\Php71\Rector\FuncCall\CountOnNullRector\Fixture;
+
+trait SkipTrait
+{
+    public function run()
+    {
+        return count($this->getItems());
+    }
+}
diff --git a/rules/Php71/Rector/FuncCall/CountOnNullRector.php b/rules/Php71/Rector/FuncCall/CountOnNullRector.php
@@ -19,6 +19,7 @@
 use PhpParser\Node\Scalar\LNumber;
 use PhpParser\NodeTraverser;
 use PHPStan\Analyser\Scope;
+use PHPStan\Reflection\ClassReflection;
 use PHPStan\Type\ArrayType;
 use PHPStan\Type\NullType;
 use PHPStan\Type\Type;
@@ -85,6 +86,10 @@ public function getNodeTypes(): array
      */
     public function refactorWithScope(Node $node, Scope $scope): int|Ternary|null|FuncCall
     {
+        if ($this->isInsideTrait($scope)) {
+            return null;
+        }
+
         if ($node instanceof Ternary) {
             if ($this->shouldSkipTernaryIfElseCountFuncCall($node)) {
                 return NodeTraverser::DONT_TRAVERSE_CHILDREN;
@@ -218,4 +223,14 @@ private function refactorArrayType(
 
         return $this->castToArray($countedExpr, $funcCall);
     }
+
+    private function isInsideTrait(Scope $scope): bool
+    {
+        $classReflection = $scope->getClassReflection();
+        if (! $classReflection instanceof ClassReflection) {
+            return false;
+        }
+
+        return $classReflection->isTrait();
+    }
 }