[DeadCode] Skip nullable array on RemoveUnusedNonEmptyArrayBeforeFore…

…achRector (#5375)

* [DeadCode] Skip nullable array on RemoveUnusedNonEmptyArrayBeforeForeachRector

* updaet

* Fixed 🎉

* comment for future reference

rules-tests/DeadCode/Rector/If_/RemoveUnusedNonEmptyArrayBeforeForeachRector/Fixture/skip_nullable_array.php.inc

@@ -0,0 +1,19 @@
+<?php
+
+namespace Rector\Tests\DeadCode\Rector\If_\RemoveUnusedNonEmptyArrayBeforeForeachRector\Fixture;
+
+class SkipNullableArray
+{
+    public function run(?array $values) {
+        if (empty($values)) {
+            return;
+        }
+
+        foreach ($values as $value) {
+            echo $value;
+        }
+    }
+}
+
+?>
+

rules/DeadCode/Rector/If_/RemoveUnusedNonEmptyArrayBeforeForeachRector.php

@@ -8,6 +8,7 @@
 use PhpParser\Node\Expr;
 use PhpParser\Node\Expr\ArrayDimFetch;
 use PhpParser\Node\Expr\BinaryOp\BooleanAnd;
+use PhpParser\Node\Expr\Empty_;
 use PhpParser\Node\Expr\Variable;
 use PhpParser\Node\Stmt;
 use PhpParser\Node\Stmt\Foreach_;
@@ -177,6 +178,19 @@ private function refactorStmtsAware(StmtsAwareInterface $stmtsAware): ?StmtsAwar
                 continue;
             }
 
+            /** @var Empty_ $empty */
+            $empty = $previousStmt->cond;
+            // scope need to be pulled from Empty_ node to ensure it get correct type
+            $scope = $empty->getAttribute(AttributeKey::SCOPE);
+            if (! $scope instanceof Scope) {
+                continue;
+            }
+
+            $ifType = $scope->getNativeType($empty->expr);
+            if (! $ifType->isArray()->yes()) {
+                continue;
+            }
+
             unset($stmtsAware->stmts[$key - 1]);
             return $stmtsAware;
         }