-
-
Notifications
You must be signed in to change notification settings - Fork 340
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Skip cond with side effect in RemoveDeadConditionAboveReturnRector (#…
…5424) * Create skip_not_readonly_function_call_in_condition.php.inc #8381 Rector should not remove if() conditions if they contain a function call that is not proven read-only * tidy up * Skip cond with side effect --------- Co-authored-by: noother <noothy@gmail.com>
- Loading branch information
1 parent
57292bc
commit 8724fee
Showing
2 changed files
with
44 additions
and
7 deletions.
There are no files selected for viewing
15 changes: 15 additions & 0 deletions
15
...eturn_/RemoveDeadConditionAboveReturnRector/Fixture/skip_method_call_in_condition.php.inc
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
<?php | ||
|
||
namespace Rector\Tests\DeadCode\Rector\Return_\RemoveDeadConditionAboveReturnRector\Fixture; | ||
|
||
final class SkipMethodCallInCondition | ||
{ | ||
public function saveMyEntity($entity): bool | ||
{ | ||
if ($entity->save()) { | ||
return true; | ||
} | ||
|
||
return true; | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters