[TypeDeclaration] Skip on ArrayDimFetch on EmptyOnNullableObjectToIns…

…tanceOfRector (#3473)

* [TypeDeclaration] Skip on ArrayDimFetch on EmptyOnNullableObjectToInstanceOfRector

* Fixed 🎉

* final touch: eol

rules-tests/TypeDeclaration/Rector/Empty_/EmptyOnNullableObjectToInstanceOfRector/Fixture/skip_on_array_dim_fetch.php.inc

@@ -0,0 +1,23 @@
+<?php
+
+namespace Rector\Tests\TypeDeclaration\Rector\Empty_\EmptyOnNullableObjectToInstanceOfRector\Fixture;
+
+use Rector\Tests\NodeTypeResolver\PerNodeTypeResolver\VariableTypeResolver\Source\AnotherType;
+
+final class SkipOnArrayDimFetch
+{
+    /**
+     * @var AnotherType[]
+     */
+    private $data = [];
+
+    public function run($key): AnotherType
+    {
+        if (! empty($this->data[$key])) {
+            return $this->data[$key];
+        }
+
+        $this->data[$key] = new AnotherType();
+        return $this->data[$key];
+    }
+}

rules/TypeDeclaration/Rector/Empty_/EmptyOnNullableObjectToInstanceOfRector.php

@@ -5,6 +5,7 @@
 namespace Rector\TypeDeclaration\Rector\Empty_;
 
 use PhpParser\Node;
+use PhpParser\Node\Expr\ArrayDimFetch;
 use PhpParser\Node\Expr\BooleanNot;
 use PhpParser\Node\Expr\Empty_;
 use PhpParser\Node\Expr\Instanceof_;
@@ -81,6 +82,10 @@ public function refactor(Node $node): ?Node
             $isNegated = false;
         }
 
+        if ($empty->expr instanceof ArrayDimFetch) {
+            return null;
+        }
+
         $exprType = $this->getType($empty->expr);
         if (! $exprType instanceof ObjectType) {
             return null;