Remove array function from RemoveEmptyMethodCallRector as too narrow (#…

…3930)
rectorphp · May 22, 2023 · 88f17e9 · 88f17e9
1 parent 112e490
commit 88f17e9
Show file tree

Hide file tree

Showing 3 changed files with 0 additions and 69 deletions.
diff --git a/...MethodCall/RemoveEmptyMethodCallRector/Fixture/void_return_type_in_arrow_function.php.inc b/...MethodCall/RemoveEmptyMethodCallRector/Fixture/void_return_type_in_arrow_function.php.inc
diff --git a/...ethodCall/RemoveEmptyMethodCallRector/Fixture/void_return_type_in_arrow_function2.php.inc b/...ethodCall/RemoveEmptyMethodCallRector/Fixture/void_return_type_in_arrow_function2.php.inc
diff --git a/rules/DeadCode/Rector/MethodCall/RemoveEmptyMethodCallRector.php b/rules/DeadCode/Rector/MethodCall/RemoveEmptyMethodCallRector.php
@@ -6,9 +6,7 @@
 
 use PhpParser\Node;
 use PhpParser\Node\Arg;
-use PhpParser\Node\Expr\ArrowFunction;
 use PhpParser\Node\Expr\Assign;
-use PhpParser\Node\Expr\ConstFetch;
 use PhpParser\Node\Expr\MethodCall;
 use PhpParser\Node\Stmt\Class_;
 use PhpParser\Node\Stmt\ClassLike;
@@ -115,10 +113,6 @@ public function refactorWithScope(Node $node, Scope $scope): ?Node
             return $this->nodeFactory->createFalse();
         }
 
-        if ($parentNode instanceof ArrowFunction && $this->nodeComparator->areNodesEqual($parentNode->expr, $node)) {
-            return $this->processArrowFunction($parentNode, $node);
-        }
-
         if (! $parentNode instanceof Expression) {
             return null;
         }
@@ -191,15 +185,4 @@ private function shouldSkipClassMethod(
 
         return ! $classMethod->isPrivate();
     }
-
-    private function processArrowFunction(ArrowFunction $arrowFunction, MethodCall $methodCall): MethodCall | ConstFetch
-    {
-        $parentParentNode = $arrowFunction->getAttribute(AttributeKey::PARENT_NODE);
-        if ($parentParentNode instanceof Expression) {
-            $this->removeNode($arrowFunction);
-            return $methodCall;
-        }
-
-        return $this->nodeFactory->createFalse();
-    }
 }