recursion is not needed, as Rector now works till there is something …

…to change
rectorphp · Aug 2, 2021 · 8c4c7d0 · 8c4c7d0
1 parent 5145487
commit 8c4c7d0
Showing 1 changed file with 4 additions and 18 deletions.
diff --git a/rules/DeadCode/Rector/Plus/RemoveDeadZeroAndOneOperationRector.php b/rules/DeadCode/Rector/Plus/RemoveDeadZeroAndOneOperationRector.php
@@ -82,29 +82,15 @@ public function getNodeTypes(): array
      */
     public function refactor(Node $node): ?Node
     {
-        $changedNode = null;
-        $previousNode = $node;
+//        $changedNode = null;
+//        $previousNode = $node;
 
         if ($node instanceof AssignOp) {
-            $changedNode = $this->processAssignOp($node);
+            return $this->processAssignOp($node);
         }
 
         // -, +
-        if ($node instanceof BinaryOp) {
-            $changedNode = $this->processBinaryOp($node);
-        }
-
-        // recurse nested combinations
-        while ($changedNode !== null && ! $this->nodeComparator->areNodesEqual($previousNode, $changedNode)) {
-            $previousNode = $changedNode;
-
-            // nothing more to change, return last node
-            if (! $changedNode instanceof Node) {
-                return $previousNode;
-            }
-        }
-
-        return $changedNode;
+        return $this->processBinaryOp($node);
     }
 
     private function processAssignOp(Node $node): ?Expr