[Strict] Skip empty() from param doc on DisallowedEmptyRuleFixerRector (

#4550)

rules-tests/Strict/Rector/Empty_/DisallowedEmptyRuleFixerRector/Fixture/skip_empty_from_param_doc.php.inc

@@ -0,0 +1,16 @@
+<?php
+
+namespace Rector\Tests\Strict\Rector\Empty_\DisallowedEmptyRuleFixerRector\Fixture;
+
+class SkipEmptyFromParamDoc
+{
+    /**
+     * @param string $value
+     */
+    public function getLabel($value)
+    {
+        if (empty($value)) {
+
+        }
+    }
+}

rules-tests/Strict/Rector/Empty_/DisallowedEmptyRuleFixerRector/Fixture/skip_multi_union_types_from_docs.php.inc

@@ -0,0 +1,14 @@
+<?php
+
+namespace Rector\Tests\Strict\Rector\Empty_\DisallowedEmptyRuleFixerRector\Fixture;
+
+final class SkipMultiUnionTypesFromDoc
+{
+    /**
+     * @param int|int[]|null|string $id
+     */
+    public function get($id)
+    {
+        return empty($id);
+    }
+}

rules-tests/Strict/Rector/Empty_/DisallowedEmptyRuleFixerRector/Fixture/skip_negated_union_types_from_doc.php.inc

@@ -0,0 +1,14 @@
+<?php
+
+namespace Rector\Tests\Strict\Rector\Empty_\DisallowedEmptyRuleFixerRector\Fixture;
+
+final class SkipNegatedUnionTypeFromDoc
+{
+    /**
+     * @param int|int[]|string $value
+     */
+    public function run($value)
+    {
+        return ! empty($value);
+    }
+}

rules/Strict/Rector/Empty_/DisallowedEmptyRuleFixerRector.php

@@ -13,6 +13,7 @@
 use PhpParser\Node\Expr\Isset_;
 use PHPStan\Analyser\Scope;
 use Rector\Core\Contract\Rector\ConfigurableRectorInterface;
+use Rector\Core\NodeAnalyzer\ExprAnalyzer;
 use Rector\Strict\NodeFactory\ExactCompareFactory;
 use Rector\Strict\Rector\AbstractFalsyScalarRuleFixerRector;
 use Symplify\RuleDocGenerator\ValueObject\CodeSample\ConfiguredCodeSample;
@@ -25,6 +26,7 @@ final class DisallowedEmptyRuleFixerRector extends AbstractFalsyScalarRuleFixerR
 {
     public function __construct(
         private readonly ExactCompareFactory $exactCompareFactory,
+        private readonly ExprAnalyzer $exprAnalyzer
     ) {
     }
 
@@ -98,6 +100,10 @@ private function refactorBooleanNot(BooleanNot $booleanNot, Scope $scope): Expr|
             return $this->createDimFetchBooleanAnd($empty);
         }
 
+        if ($this->exprAnalyzer->isNonTypedFromParam($empty->expr)) {
+            return null;
+        }
+
         $emptyExprType = $scope->getType($empty->expr);
 
         return $this->exactCompareFactory->createNotIdenticalFalsyCompare(
@@ -109,6 +115,10 @@ private function refactorBooleanNot(BooleanNot $booleanNot, Scope $scope): Expr|
 
     private function refactorEmpty(Empty_ $empty, Scope $scope, bool $treatAsNonEmpty): Expr|null
     {
+        if ($this->exprAnalyzer->isNonTypedFromParam($empty->expr)) {
+            return null;
+        }
+
         $exprType = $scope->getType($empty->expr);
         return $this->exactCompareFactory->createIdenticalFalsyCompare($exprType, $empty->expr, $treatAsNonEmpty);
     }