[CodingStyle] Skip filled by construct on AddArrayDefaultToArrayPrope…

…rtyRector (#4549)

rules-tests/CodingStyle/Rector/Class_/AddArrayDefaultToArrayPropertyRector/Fixture/skip_filled_by_construct.php.inc

@@ -0,0 +1,15 @@
+<?php
+
+namespace Rector\Tests\CodingStyle\Rector\Class_\AddArrayDefaultToArrayPropertyRector\Fixture;
+
+final class SkipFilledByConstruct
+{
+    /** @var string[] */
+    private array $arr;
+
+    public function __construct(array $arr)
+    {
+        $this->arr = $arr;
+    }
+}
+

rules/CodingStyle/Rector/Class_/AddArrayDefaultToArrayPropertyRector.php

@@ -20,6 +20,7 @@
 use Rector\Core\NodeAnalyzer\PropertyFetchAnalyzer;
 use Rector\Core\Rector\AbstractRector;
 use Rector\Privatization\NodeManipulator\VisibilityManipulator;
+use Rector\TypeDeclaration\AlreadyAssignDetector\ConstructorAssignDetector;
 use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
 use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
 
@@ -32,7 +33,8 @@ final class AddArrayDefaultToArrayPropertyRector extends AbstractRector
     public function __construct(
         private readonly PropertyFetchAnalyzer $propertyFetchAnalyzer,
         private readonly IterableTypeAnalyzer $iterableTypeAnalyzer,
-        private readonly VisibilityManipulator $visibilityManipulator
+        private readonly VisibilityManipulator $visibilityManipulator,
+        private readonly ConstructorAssignDetector $constructorAssignDetector
     ) {
     }
 
@@ -115,7 +117,7 @@ public function refactor(Node $node): ?Node
     private function collectPropertyNamesWithMissingDefaultArray(Class_ $class): array
     {
         $propertyNames = [];
-        $this->traverseNodesWithCallable($class, function (Node $node) use (&$propertyNames) {
+        $this->traverseNodesWithCallable($class, function (Node $node) use ($class, &$propertyNames) {
             if (! $node instanceof Property) {
                 return null;
             }
@@ -134,7 +136,12 @@ private function collectPropertyNamesWithMissingDefaultArray(Class_ $class): arr
                     return null;
                 }
 
-                $propertyNames[] = $this->getName($propertyProperty);
+                $propertyName = $this->getName($propertyProperty);
+                if ($this->constructorAssignDetector->isPropertyAssigned($class, $propertyName)) {
+                    return null;
+                }
+
+                $propertyNames[] = $propertyName;
             }
 
             return null;