Little cleanup (#2810)

rectorphp · Aug 20, 2022 · 8e75310 · 8e75310
1 parent a33b200
commit 8e75310
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 5 deletions.
diff --git a/packages/BetterPhpDocParser/PhpDocManipulator/PhpDocClassRenamer.php b/packages/BetterPhpDocParser/PhpDocManipulator/PhpDocClassRenamer.php
@@ -11,6 +11,7 @@
 use Rector\BetterPhpDocParser\PhpDocInfo\PhpDocInfo;
 use Rector\BetterPhpDocParser\PhpDocParser\ClassAnnotationMatcher;
 use Rector\BetterPhpDocParser\ValueObject\PhpDoc\DoctrineAnnotation\CurlyListNode;
+use Rector\BetterPhpDocParser\ValueObject\PhpDocAttributeKey;
 
 final class PhpDocClassRenamer
 {
@@ -67,7 +68,7 @@ private function processAssertChoiceTagValueNode(array $oldToNewClasses, PhpDocI
             $classNameArrayItemNode->value = $newClass;
 
             // trigger reprint
-            $classNameArrayItemNode->setAttribute('orig_node', null);
+            $classNameArrayItemNode->setAttribute(PhpDocAttributeKey::ORIG_NODE, null);
             break;
         }
     }
@@ -118,7 +119,7 @@ private function processSerializerTypeTagValueNode(array $oldToNewClasses, PhpDo
                     $newClass
                 );
 
-                $classNameArrayItemNode->setAttribute('orig_node', null);
+                $classNameArrayItemNode->setAttribute(PhpDocAttributeKey::ORIG_NODE, null);
             }
 
             $currentTypeArrayItemNode = $doctrineAnnotationTagValueNode->getValue('type');
@@ -160,7 +161,7 @@ private function processDoctrineToMany(
             }
 
             $targetEntityArrayItemNode->value = $newClass;
-            $targetEntityArrayItemNode->setAttribute('orig_node', null);
+            $targetEntityArrayItemNode->setAttribute(PhpDocAttributeKey::ORIG_NODE, null);
         }
     }
 }
diff --git a/...ncCall/VersionCompareFuncCallToConstantRector/Fixture/skip_indirect_string_number.php.inc b/...ncCall/VersionCompareFuncCallToConstantRector/Fixture/skip_indirect_string_number.php.inc
@@ -4,7 +4,7 @@ namespace Rector\Tests\CodingStyle\Rector\FuncCall\VersionCompareFuncCallToConst
 
 class SkipIndirectStringNumber
 {
-    private const MIN_PHP_VERSION = 'Php73';
+    private const MIN_PHP_VERSION = '7.2';
 
     public function run()
     {

diff --git a/...DeadCode/Rector/If_/UnwrapFutureCompatibleIfPhpVersionRector/Fixture/skip_elsefis.php.inc b/...DeadCode/Rector/If_/UnwrapFutureCompatibleIfPhpVersionRector/Fixture/skip_elsefis.php.inc
@@ -9,7 +9,7 @@ class SkipElsefis
         // current PHP: 10.0
         if (1 == version_compare(PHP_VERSION, '7.2', '<')) {
             return 'is PHP 7.1-';
-        } elseif (1 == version_compare(PHP_VERSION, 'Php73', '<')) {
+        } elseif (1 == version_compare(PHP_VERSION, '7.3', '<')) {
             return 'hop';
         } else {
             return 'is PHP 7.2+';