[CodeQuality] Remove SimplifyIfIssetToNullCoalescingRector, as overly…

… complex and should be handled by manual context (#2828)
rectorphp · Aug 24, 2022 · 9018492 · 9018492
1 parent 6306f9e
commit 9018492
Show file tree

Hide file tree

Showing 6 changed files with 2 additions and 299 deletions.
diff --git a/build/target-repository/docs/rector_rules_overview.md b/build/target-repository/docs/rector_rules_overview.md
@@ -1,12 +1,12 @@
-# 411 Rules Overview
+# 410 Rules Overview
 
 <br>
 
 ## Categories
 
 - [Arguments](#arguments) (5)
 
-- [CodeQuality](#codequality) (73)
+- [CodeQuality](#codequality) (72)
 
 - [CodingStyle](#codingstyle) (36)
 
@@ -1326,29 +1326,6 @@ Changes compared to value and return of expr to direct return
 
 <br>
 
-### SimplifyIfIssetToNullCoalescingRector
-
-Simplify binary if to null coalesce
-
-- class: [`Rector\CodeQuality\Rector\If_\SimplifyIfIssetToNullCoalescingRector`](../rules/CodeQuality/Rector/If_/SimplifyIfIssetToNullCoalescingRector.php)
-
-```diff
- final class SomeController
- {
-     public function run($possibleStatieYamlFile)
-     {
--        if (isset($possibleStatieYamlFile['import'])) {
--            $possibleStatieYamlFile['import'] = array_merge($possibleStatieYamlFile['import'], $filesToImport);
--        } else {
--            $possibleStatieYamlFile['import'] = $filesToImport;
--        }
-+        $possibleStatieYamlFile['import'] = array_merge($possibleStatieYamlFile['import'] ?? [], $filesToImport);
-     }
- }
-```
-
-<br>
-
 ### SimplifyIfNotNullReturnRector
 
 Changes redundant null check to instant return

diff --git a/config/set/code-quality.php b/config/set/code-quality.php
@@ -57,7 +57,6 @@
 use Rector\CodeQuality\Rector\If_\ShortenElseIfRector;
 use Rector\CodeQuality\Rector\If_\SimplifyIfElseToTernaryRector;
 use Rector\CodeQuality\Rector\If_\SimplifyIfExactValueReturnValueRector;
-use Rector\CodeQuality\Rector\If_\SimplifyIfIssetToNullCoalescingRector;
 use Rector\CodeQuality\Rector\If_\SimplifyIfNotNullReturnRector;
 use Rector\CodeQuality\Rector\If_\SimplifyIfNullableReturnRector;
 use Rector\CodeQuality\Rector\If_\SimplifyIfReturnBoolRector;
@@ -133,7 +132,6 @@
         SimplifyIfElseToTernaryRector::class,
         JoinStringConcatRector::class,
         ConsecutiveNullCompareReturnsToNullCoalesceQueueRector::class,
-        SimplifyIfIssetToNullCoalescingRector::class,
         ExplicitBoolCompareRector::class,
         CombineIfRector::class,
         UseIdenticalOverEqualWithSameTypeRector::class,

diff --git a/...ests/CodeQuality/Rector/If_/SimplifyIfIssetToNullCoalescingRector/Fixture/fixture.php.inc b/...ests/CodeQuality/Rector/If_/SimplifyIfIssetToNullCoalescingRector/Fixture/fixture.php.inc
diff --git a/...r/If_/SimplifyIfIssetToNullCoalescingRector/SimplifyIfIssetToNullCoalescingRectorTest.php b/...r/If_/SimplifyIfIssetToNullCoalescingRector/SimplifyIfIssetToNullCoalescingRectorTest.php
diff --git a/...s/CodeQuality/Rector/If_/SimplifyIfIssetToNullCoalescingRector/config/configured_rule.php b/...s/CodeQuality/Rector/If_/SimplifyIfIssetToNullCoalescingRector/config/configured_rule.php
diff --git a/rules/CodeQuality/Rector/If_/SimplifyIfIssetToNullCoalescingRector.php b/rules/CodeQuality/Rector/If_/SimplifyIfIssetToNullCoalescingRector.php