[PHP 8.1] Skip trait in NullToStrictStringFuncCallArgRector as unknow…

…n context (#3180)

Co-authored-by: Stephan Vierkant <stephan@vierkant.net>

rules-tests/Php81/Rector/FuncCall/NullToStrictStringFuncCallArgRector/Fixture/skip_trait.php.inc

@@ -0,0 +1,15 @@
+<?php
+
+namespace Rector\Tests\Php81\Rector\FuncCall\NullToStrictStringFuncCallArgRector\Fixture;
+
+trait SkipTrait
+{
+    public function getTitle()
+    {
+        if ($this->title === null) {
+            return null;
+        }
+
+        return trim($this->title);
+    }
+}

rules/Php81/Rector/FuncCall/NullToStrictStringFuncCallArgRector.php

@@ -17,11 +17,12 @@
 use PhpParser\Node\Scalar\String_;
 use PhpParser\Node\Stmt\Trait_;
 use PHPStan\Analyser\Scope;
+use PHPStan\Reflection\ClassReflection;
 use PHPStan\Reflection\Native\NativeFunctionReflection;
 use PHPStan\Type\ErrorType;
 use PHPStan\Type\MixedType;
 use Rector\Core\NodeAnalyzer\ArgsAnalyzer;
-use Rector\Core\Rector\AbstractRector;
+use Rector\Core\Rector\AbstractScopeAwareRector;
 use Rector\Core\Reflection\ReflectionResolver;
 use Rector\Core\ValueObject\PhpVersionFeature;
 use Rector\NodeTypeResolver\Node\AttributeKey;
@@ -33,7 +34,7 @@
 /**
  * @see \Rector\Tests\Php81\Rector\FuncCall\NullToStrictStringFuncCallArgRector\NullToStrictStringFuncCallArgRectorTest
  */
-final class NullToStrictStringFuncCallArgRector extends AbstractRector implements MinPhpVersionInterface
+final class NullToStrictStringFuncCallArgRector extends AbstractScopeAwareRector implements MinPhpVersionInterface
 {
     /**
      * @var array<string, string[]>
@@ -375,9 +376,9 @@ public function getNodeTypes(): array
     /**
      * @param FuncCall $node
      */
-    public function refactor(Node $node): ?Node
+    public function refactorWithScope(Node $node, Scope $scope): ?Node
     {
-        if ($this->shouldSkip($node)) {
+        if ($this->shouldSkip($node, $scope)) {
             return null;
         }
 
@@ -550,13 +551,18 @@ private function resolveOriginalPositions(FuncCall $funcCall): array
         return $positions;
     }
 
-    private function shouldSkip(FuncCall $funcCall): bool
+    private function shouldSkip(FuncCall $funcCall, Scope $scope): bool
     {
         $functionNames = array_keys(self::ARG_POSITION_NAME_NULL_TO_STRICT_STRING);
         if (! $this->nodeNameResolver->isNames($funcCall, $functionNames)) {
             return true;
         }
 
+        $classReflection = $scope->getClassReflection();
+        if ($classReflection instanceof ClassReflection && $classReflection->isTrait()) {
+            return true;
+        }
+
         return $funcCall->isFirstClassCallable();
     }
 }