Skip DateTime in ExpectedNameResolver (#5186)

rules-tests/Naming/Rector/ClassMethod/RenameParamToMatchTypeRector/Fixture/skip_rewindable_generator.php.inc

@@ -1,12 +1,15 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Rector\Tests\Naming\Rector\ClassMethod\RenameParamToMatchTypeRector\Fixture;
 
 use Symfony\Component\DependencyInjection\Argument\RewindableGenerator;
 
 final class SkipRewindableGenerator
 {
-    public function __construct(RewindableGenerator $items)
-    {
+    public function __construct(
+        RewindableGenerator $items
+    ) {
     }
 }

rules/Naming/Guard/BreakingVariableRenameGuard.php

@@ -188,9 +188,16 @@ private function isDateTimeAtNamingConvention(Param $param): bool
 
     private function isGenerator(Param $param): bool
     {
-        return $this->nodeTypeResolver->isObjectType(
-            $param,
-            new ObjectType('Symfony\Component\DependencyInjection\Argument\RewindableGenerator')
-        );
+        if (! $param->type instanceof Node) {
+            return false;
+        }
+
+        $paramType = $this->nodeTypeResolver->getType($param);
+        if (! $paramType instanceof ObjectType) {
+            return false;
+        }
+
+        return $paramType->isInstanceOf('Symfony\Component\DependencyInjection\Argument\RewindableGenerator')
+            ->yes();
     }
 }

rules/Naming/Naming/ExpectedNameResolver.php

@@ -119,8 +119,7 @@ public function resolveForCall(MethodCall | StaticCall | FuncCall $expr): ?strin
             return null;
         }
 
-        if ($returnedType instanceof ObjectType && $returnedType->isInstanceOf('DateTimeInterface')->yes()) {
-            // skip date time, as custom naming
+        if ($this->isDateTimeType($returnedType)) {
             return null;
         }
 
@@ -213,4 +212,21 @@ private function resolveReturnTypeFromArrayType(ArrayType $arrayType): ?Type
 
         return $arrayType->getItemType();
     }
+
+    /**
+     * Skip date time, as custom naming
+     */
+    private function isDateTimeType(Type $type): bool
+    {
+        if (! $type instanceof ObjectType) {
+            return false;
+        }
+
+        if ($type->isInstanceOf('DateTimeInterface')->yes()) {
+            return true;
+        }
+
+        return $type->isInstanceOf('DateTime')
+            ->yes();
+    }
 }

stubs/Symfony/Component/DependencyInjection/Argument/RewindableGenerator.php

@@ -0,0 +1,41 @@
+<?php
+
+namespace Symfony\Component\DependencyInjection\Argument;
+
+if (class_exists('Symfony\\Component\\DependencyInjection\\Argument\\RewindableGenerator')) {
+    return;
+}
+
+/**
+ * @internal
+ */
+class RewindableGenerator implements \IteratorAggregate, \Countable
+{
+    private $generator;
+    private $count;
+
+    /**
+     * @param int|callable $count
+     */
+    public function __construct(callable $generator, $count)
+    {
+        $this->generator = $generator;
+        $this->count = $count;
+    }
+
+    public function getIterator(): \Traversable
+    {
+        $g = $this->generator;
+
+        return $g();
+    }
+
+    public function count(): int
+    {
+        if (\is_callable($count = $this->count)) {
+            $this->count = $count();
+        }
+
+        return $this->count;
+    }
+}