Skip to content

Commit

Permalink
remove fixed phpstan errors
Browse files Browse the repository at this point in the history
  • Loading branch information
TomasVotruba committed Mar 3, 2022
1 parent efd8084 commit 978fd78
Showing 1 changed file with 0 additions and 19 deletions.
19 changes: 0 additions & 19 deletions phpstan.neon
Original file line number Diff line number Diff line change
Expand Up @@ -238,11 +238,6 @@ parameters:
message: '#Property with protected modifier is not allowed\. Use interface contract method instead#'
path: 'packages/BetterPhpDocParser/ValueObject/PhpDoc/DoctrineAnnotation/AbstractValuesAwareNode.php'

-
message: '#Do not use setter on a service#'
paths:
- packages/NodeTypeResolver/PhpDocNodeVisitor/*PhpDocNodeVisitor.php

# known type
- '#Parameter \#3 \$pseudoNamespaceToNamespace of method Rector\\NodeTypeResolver\\PhpDocNodeVisitor\\UnderscoreRenamePhpDocNodeVisitor\:\:shouldSkip\(\) expects Rector\\Renaming\\ValueObject\\PseudoNamespaceToNamespace, Rector\\Renaming\\ValueObject\\PseudoNamespaceToNamespace\|null given#'

Expand All @@ -261,8 +256,6 @@ parameters:

- '#Cannot call method getSmartFileInfo\(\) on Rector\\Core\\ValueObject\\Application\\File\|null#'

- '#Method Rector\\Core\\Tests\\DependencyInjection\\ConfigurableRectorImportConfigCallsMergeTest\:\:provideData\(\) return type has no value type specified in iterable type Iterator#'

-
message: '#Function "function_exists\(\)" cannot be used/left in the code#'
paths:
Expand All @@ -273,7 +266,6 @@ parameters:
message: '#File processor must require Rector rules in constructor via TypeRectorInterface\[\] \$typeRectors array autowire#'
path: src/Application/FileProcessor/PhpFileProcessor.php

- '#Use required typed property over of nullable property#'
- '#Method Rector\\BetterPhpDocParser\\PhpDocParser\\BetterPhpDocParser\:\:parseChildAndStoreItsPositions\(\) should return PHPStan\\PhpDocParser\\Ast\\PhpDoc\\PhpDocTagNode\|PHPStan\\PhpDocParser\\Ast\\PhpDoc\\PhpDocTextNode but returns PHPStan\\PhpDocParser\\Ast\\PhpDoc\\PhpDocChildNode#'

# deserves better architecture
Expand Down Expand Up @@ -371,8 +363,6 @@ parameters:
- '#Access to an undefined property PhpParser\\Node\\Arg\|PhpParser\\Node\\VariadicPlaceholder\:\:\$value#'
- '#(.*?), array<PhpParser\\Node\\Arg\|PhpParser\\Node\\VariadicPlaceholder\> given#'

- '#Parameter "\w+" cannot have default value#'

# scope & mutating scope mish-mash
- '#Parameter \#3 \$nodeCallback of method PHPStan\\Analyser\\NodeScopeResolver\:\:processNodes\(\) expects callable\(PhpParser\\Node, PHPStan\\Analyser\\Scope\)\: void, Closure\(PhpParser\\Node, PHPStan\\Analyser\\MutatingScope\)\: void given#'

Expand Down Expand Up @@ -506,15 +496,6 @@ parameters:

- '#Call to function property_exists\(\) with PhpParser\\Node\\Stmt\\ClassLike and (.*?) will always evaluate to true#'

# code sample configuration
-
message: '#new <class\> is limited to 3 "new <class\>\(new <class\>\)\)" nesting to each other\. You have 4 nesting#'
paths:
- rules/Renaming/Rector/ClassConstFetch/RenameClassConstFetchRector.php
- rules/Arguments/Rector/ClassMethod/ArgumentAdderRector.php
- rules/TypeDeclaration/Rector/ClassMethod/AddParamTypeDeclarationRector.php
- rules/Transform/Rector/Assign/PropertyFetchToMethodCallRector.php

# skipped on purpose, as ctor overrie
- '#Rector\\StaticTypeMapper\\ValueObject\\Type\\SimpleStaticType\:\:__construct\(\) does not call parent constructor from PHPStan\\Type\\StaticType#'

Expand Down

0 comments on commit 978fd78

Please sign in to comment.