[TypeDeclaration] Skip default numeric string on param int on ParamTy…

…peByMethodCallTypeRector (#5210)

* [TypeDeclaration] Skip default numeric string on param int on ParamTypeByMethodCallTypeRector

* udpate code

* Fixed 🎉

* Fixed 🎉

* more fixture

* fix

rules-tests/TypeDeclaration/Rector/ClassMethod/ParamTypeByMethodCallTypeRector/Fixture/skip_default_numeric_string_param_int.php.inc

@@ -0,0 +1,15 @@
+<?php
+
+namespace Rector\Tests\TypeDeclaration\Rector\ClassMethod\ParamTypeByMethodCallTypeRector\Fixture;
+
+final class SkipDefaultNumericStringParamInt
+{
+    public function go($value = '1')
+    {
+        $this->execute($value);
+    }
+
+    private function execute(int $value)
+    {
+    }
+}

rules-tests/TypeDeclaration/Rector/ClassMethod/ParamTypeByMethodCallTypeRector/Fixture/with_default_constant_integer_type_param_int.php.inc

@@ -0,0 +1,35 @@
+<?php
+
+namespace Rector\Tests\TypeDeclaration\Rector\ClassMethod\ParamTypeByMethodCallTypeRector\Fixture;
+
+final class WithDefaultConstantIntegerTypeParamInt
+{
+    public function go($value = 1)
+    {
+        $this->execute($value);
+    }
+
+    private function execute(int $value)
+    {
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Tests\TypeDeclaration\Rector\ClassMethod\ParamTypeByMethodCallTypeRector\Fixture;
+
+final class WithDefaultConstantIntegerTypeParamInt
+{
+    public function go(int $value = 1)
+    {
+        $this->execute($value);
+    }
+
+    private function execute(int $value)
+    {
+    }
+}
+
+?>

rules/TypeDeclaration/NodeAnalyzer/CallerParamMatcher.php

@@ -4,8 +4,10 @@
 
 namespace Rector\TypeDeclaration\NodeAnalyzer;
 
+use PhpParser\Node;
 use PhpParser\Node\Arg;
 use PhpParser\Node\ComplexType;
+use PhpParser\Node\Expr;
 use PhpParser\Node\Expr\FuncCall;
 use PhpParser\Node\Expr\MethodCall;
 use PhpParser\Node\Expr\StaticCall;
@@ -20,12 +22,16 @@
 use PHPStan\Reflection\ClassReflection;
 use Rector\Core\PhpParser\AstResolver;
 use Rector\NodeNameResolver\NodeNameResolver;
+use Rector\NodeTypeResolver\TypeComparator\TypeComparator;
+use Rector\StaticTypeMapper\StaticTypeMapper;
 
 final class CallerParamMatcher
 {
     public function __construct(
         private readonly NodeNameResolver $nodeNameResolver,
-        private readonly AstResolver $astResolver
+        private readonly AstResolver $astResolver,
+        private readonly StaticTypeMapper $staticTypeMapper,
+        private readonly TypeComparator $typeComparator
     ) {
     }
 
@@ -39,7 +45,26 @@ public function matchCallParamType(
             return null;
         }
 
-        return $callParam->type;
+        if (! $param->default instanceof Expr) {
+            return $callParam->type;
+        }
+
+        if (! $callParam->type instanceof Node) {
+            return null;
+        }
+
+        $callParamType = $this->staticTypeMapper->mapPhpParserNodePHPStanType($callParam->type);
+        $defaultType = $this->staticTypeMapper->mapPhpParserNodePHPStanType($param->default);
+
+        if ($this->typeComparator->areTypesEqual($callParamType, $defaultType)) {
+            return $callParam->type;
+        }
+
+        if ($this->typeComparator->isSubtype($defaultType, $callParamType)) {
+            return $callParam->type;
+        }
+
+        return null;
     }
 
     public function matchParentParam(StaticCall $parentStaticCall, Param $param, Scope $scope): ?Param