Skip to content

[TypeDeclaration] Skip default numeric string on param int on ParamTypeByMethodCallTypeRector#5210

Merged
samsonasik merged 6 commits intomainfrom
skip-default-numeric-stirng-param-int
Oct 28, 2023
Merged

[TypeDeclaration] Skip default numeric string on param int on ParamTypeByMethodCallTypeRector#5210
samsonasik merged 6 commits intomainfrom
skip-default-numeric-stirng-param-int

Conversation

@samsonasik
Copy link
Copy Markdown
Member

The following code should be skipped:

final class SkipDefaultNumericStringParamInt
{
    public function go($value = '1')
    {
        return $this->execute($value);
    }

    private function execute(int $value)
    {
    }
}

as cause fatal error with add int param,

ref https://3v4l.org/50JON
ref https://getrector.com/demo/5394a6db-9a13-41ba-8910-4b3d890e5ac7

@samsonasik
Copy link
Copy Markdown
Member Author

Fixed 🎉

@samsonasik
Copy link
Copy Markdown
Member Author

All checks have passed 🎉 @TomasVotruba I am merging it ;)

@samsonasik samsonasik merged commit 97d095f into main Oct 28, 2023
@samsonasik samsonasik deleted the skip-default-numeric-stirng-param-int branch October 28, 2023 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant