[CodingStyle] Remove UseMessageVariableForSprintfInSymfonyStyleRector…

… as local custom rule (#1419)

build/target-repository/docs/rector_rules_overview.md

@@ -1,4 +1,4 @@
-# 502 Rules Overview
+# 501 Rules Overview
 
 <br>
 
@@ -10,7 +10,7 @@
 
 - [CodeQuality](#codequality) (70)
 
-- [CodingStyle](#codingstyle) (35)
+- [CodingStyle](#codingstyle) (34)
 
 - [Compatibility](#compatibility) (1)
 
@@ -2471,28 +2471,6 @@ Use ++ increment instead of `$var += 1`
 
 <br>
 
-### UseMessageVariableForSprintfInSymfonyStyleRector
-
-Decouple `$message` property from `sprintf()` calls in `$this->symfonyStyle->method()`
-
-- class: [`Rector\CodingStyle\Rector\MethodCall\UseMessageVariableForSprintfInSymfonyStyleRector`](../rules/CodingStyle/Rector/MethodCall/UseMessageVariableForSprintfInSymfonyStyleRector.php)
-
-```diff
- use Symfony\Component\Console\Style\SymfonyStyle;
-
- final class SomeClass
- {
-     public function run(SymfonyStyle $symfonyStyle)
-     {
--        $symfonyStyle->info(sprintf('Hi %s', 'Tom'));
-+        $message = sprintf('Hi %s', 'Tom');
-+        $symfonyStyle->info($message);
-     }
- }
-```
-
-<br>
-
 ### VarConstantCommentRector
 
 Constant should have a `@var` comment with type

config/set/code-quality-strict.php

@@ -4,12 +4,10 @@
 
 use Rector\CodeQuality\Rector\Identical\FlipTypeControlToUseExclusiveTypeRector;
 use Rector\CodingStyle\Rector\FuncCall\CountArrayToEmptyArrayComparisonRector;
-use Rector\CodingStyle\Rector\MethodCall\UseMessageVariableForSprintfInSymfonyStyleRector;
 use Symfony\Component\DependencyInjection\Loader\Configurator\ContainerConfigurator;
 
 return static function (ContainerConfigurator $containerConfigurator): void {
     $services = $containerConfigurator->services();
     $services->set(CountArrayToEmptyArrayComparisonRector::class);
-    $services->set(UseMessageVariableForSprintfInSymfonyStyleRector::class);
     $services->set(FlipTypeControlToUseExclusiveTypeRector::class);
 };

config/set/coding-style.php

@@ -20,7 +20,6 @@
 use Rector\CodingStyle\Rector\FuncCall\VersionCompareFuncCallToConstantRector;
 use Rector\CodingStyle\Rector\If_\NullableCompareToNullRector;
 use Rector\CodingStyle\Rector\Include_\FollowRequireByDirRector;
-use Rector\CodingStyle\Rector\MethodCall\UseMessageVariableForSprintfInSymfonyStyleRector;
 use Rector\CodingStyle\Rector\Plus\UseIncrementAssignRector;
 use Rector\CodingStyle\Rector\PostInc\PostIncDecToPreIncDecRector;
 use Rector\CodingStyle\Rector\Property\AddFalseDefaultToBoolPropertyRector;
@@ -57,7 +56,6 @@
     $services->set(MakeInheritedMethodVisibilitySameAsParentRector::class);
     $services->set(CallUserFuncArrayToVariadicRector::class);
     $services->set(VersionCompareFuncCallToConstantRector::class);
-    $services->set(UseMessageVariableForSprintfInSymfonyStyleRector::class);
 
     $services->set(FuncCallToConstFetchRector::class)
         ->configure([

packages/Set/ValueObject/SetList.php

@@ -35,11 +35,6 @@ final class SetList implements SetListInterface
      */
     final public const CODING_STYLE = __DIR__ . '/../../../config/set/coding-style.php';
 
-    /**
-     * @var string
-     */
-    final public const CODING_STYLE_ADVANCED = __DIR__ . '/../../../config/set/coding-style-advanced.php';
-
     /**
      * @var string
      */

rector.php

@@ -24,7 +24,6 @@
 
     // include sets
     $containerConfigurator->import(SetList::CODING_STYLE);
-    $containerConfigurator->import(SetList::CODING_STYLE_ADVANCED);
     $containerConfigurator->import(SetList::CODE_QUALITY);
     $containerConfigurator->import(SetList::DEAD_CODE);
     $containerConfigurator->import(SetList::PRIVATIZATION);