[CodingStyle] Skip test method in UnSpreadOperatorRector (#1106)

rectorphp · Oct 29, 2021 · 9efb3a5 · 9efb3a5
1 parent 5ca93fd
commit 9efb3a5
Show file tree

Hide file tree

Showing 2 changed files with 27 additions and 4 deletions.
diff --git a/...ts/CodingStyle/Rector/ClassMethod/UnSpreadOperatorRector/Fixture/skip_test_method.php.inc b/...ts/CodingStyle/Rector/ClassMethod/UnSpreadOperatorRector/Fixture/skip_test_method.php.inc
@@ -0,0 +1,12 @@
+<?php
+
+namespace Rector\Tests\CodingStyle\Rector\ClassMethod\UnSpreadOperatorRector\Fixture;
+
+use PHPUnit\Framework\TestCase;
+
+final class SkipTestMethod extends TestCase
+{
+    public function test(string $name, ...$items)
+    {
+    }
+}
diff --git a/rules/CodingStyle/Rector/ClassMethod/UnSpreadOperatorRector.php b/rules/CodingStyle/Rector/ClassMethod/UnSpreadOperatorRector.php
@@ -10,11 +10,14 @@
 use PhpParser\Node\Expr\MethodCall;
 use PhpParser\Node\Identifier;
 use PhpParser\Node\Stmt\ClassMethod;
+use PHPStan\Analyser\Scope;
 use PHPStan\Reflection\MethodReflection;
+use PHPUnit\Framework\TestCase;
 use Rector\CodingStyle\NodeAnalyzer\SpreadVariablesCollector;
 use Rector\CodingStyle\Reflection\VendorLocationDetector;
 use Rector\Core\Rector\AbstractRector;
 use Rector\Core\Reflection\ReflectionResolver;
+use Rector\NodeTypeResolver\Node\AttributeKey;
 use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
 use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
 
@@ -79,14 +82,22 @@ public function getNodeTypes(): array
     public function refactor(Node $node): ?Node
     {
         if ($node instanceof ClassMethod) {
-            return $this->processUnspreadOperatorClassMethodParams($node);
+            return $this->refactorClassMethod($node);
         }
 
-        return $this->processUnspreadOperatorMethodCallArgs($node);
+        return $this->refactorMethodCall($node);
     }
 
-    private function processUnspreadOperatorClassMethodParams(ClassMethod $classMethod): ?ClassMethod
+    private function refactorClassMethod(ClassMethod $classMethod): ?ClassMethod
     {
+        $scope = $classMethod->getAttribute(AttributeKey::SCOPE);
+        if ($scope instanceof Scope && $classMethod->isPublic()) {
+            $classReflection = $scope->getClassReflection();
+            if ($classReflection->isSubclassOf(TestCase::class)) {
+                return null;
+            }
+        }
+
         $spreadParams = $this->spreadVariablesCollector->resolveFromClassMethod($classMethod);
         if ($spreadParams === []) {
             return null;
@@ -101,7 +112,7 @@ private function processUnspreadOperatorClassMethodParams(ClassMethod $classMeth
         return $classMethod;
     }
 
-    private function processUnspreadOperatorMethodCallArgs(MethodCall $methodCall): ?MethodCall
+    private function refactorMethodCall(MethodCall $methodCall): ?MethodCall
     {
         $methodReflection = $this->reflectionResolver->resolveMethodReflectionFromMethodCall($methodCall);
         if (! $methodReflection instanceof MethodReflection) {