[TypeDeclaration] Skip ArrayDimFetch by return array doc on AddMethod…

…CallBasedStrictParamTypeRector (#5058) * [TypeDeclaration] Skip ArrayDimFetch by return array doc on AddMethodCallBasedStrictParamTypeRector * Fixed 🎉 * clean up
rectorphp · Sep 21, 2023 · 9f88b63 · 9f88b63
1 parent 69055b5
commit 9f88b63
Show file tree

Hide file tree

Showing 2 changed files with 26 additions and 1 deletion.
diff --git a/packages/NodeTypeResolver/NodeTypeResolver.php b/packages/NodeTypeResolver/NodeTypeResolver.php
@@ -255,7 +255,7 @@ public function getNativeType(Expr $expr): Type
              *  if (!empty($parts['host'])) { }
              */
             $variableType = $scope->getNativeType($expr->var);
-            if (! $variableType instanceof ArrayType || ! $variableType->getItemType() instanceof MixedType) {
+            if (! $variableType instanceof MixedType && (! $variableType instanceof ArrayType || ! $variableType->getItemType() instanceof MixedType)) {
                 $type = $scope->getType($expr);
             }
         }

diff --git a/...ClassMethod/AddMethodCallBasedStrictParamTypeRector/Fixture/skip_return_array_doc.php.inc b/...ClassMethod/AddMethodCallBasedStrictParamTypeRector/Fixture/skip_return_array_doc.php.inc
@@ -0,0 +1,25 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\Tests\TypeDeclaration\Rector\ClassMethod\AddMethodCallBasedStrictParamTypeRector\Fixture;
+
+final class SkipReturnArrayDoc
+{
+    /**
+     * @return array<string, string>
+     */
+    private function run()
+    {
+    }
+
+    private function execute($data)
+    {
+    }
+
+    public function runData()
+    {
+        $values = $this->run();
+        $this->execute($values['data']);
+    }
+}