[DX] Inline PARALLEL_SYSTEM_ERROR_COUNT_LIMIT option to keep user sco…

…pe outside internal system (#1818)
rectorphp · Feb 15, 2022 · 9fe4426 · 9fe4426
1 parent d670c93
commit 9fe4426
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 13 deletions.
diff --git a/config/parameters.php b/config/parameters.php
@@ -22,7 +22,6 @@
     $parameters->set(Option::PARALLEL_MAX_NUMBER_OF_PROCESSES, 16);
     $parameters->set(Option::PARALLEL_JOB_SIZE, 20);
     $parameters->set(Option::PARALLEL_TIMEOUT_IN_SECONDS, 120);
-    $parameters->set(Option::PARALLEL_SYSTEM_ERROR_COUNT_LIMIT, 20);
 
     // FQN class importing
     $parameters->set(Option::AUTO_IMPORT_NAMES, false);

diff --git a/packages/Parallel/Application/ParallelFileProcessor.php b/packages/Parallel/Application/ParallelFileProcessor.php
@@ -39,6 +39,11 @@
  */
 final class ParallelFileProcessor
 {
+    /**
+     * @var int
+     */
+    private const SYSTEM_ERROR_LIMIT = 50;
+
     private ProcessPool|null $processPool = null;
 
     public function __construct(
@@ -125,9 +130,6 @@ public function process(
         };
 
         $timeoutInSeconds = $this->parameterProvider->provideIntParameter(Option::PARALLEL_TIMEOUT_IN_SECONDS);
-        $systemErrorCountLimit = $this->parameterProvider->provideIntParameter(
-            Option::PARALLEL_SYSTEM_ERROR_COUNT_LIMIT
-        );
 
         for ($i = 0; $i < $numberOfProcesses; ++$i) {
             // nothing else to process, stop now
@@ -157,8 +159,7 @@ function (array $json) use (
                     $postFileCallback,
                     &$systemErrorsCount,
                     &$reachedInternalErrorsCountLimit,
-                    $processIdentifier,
-                    $systemErrorCountLimit
+                    $processIdentifier
                 ): void {
                     // decode arrays to objects
                     foreach ($json[Bridge::SYSTEM_ERRORS] as $jsonError) {
@@ -177,7 +178,7 @@ function (array $json) use (
                     $postFileCallback($json[Bridge::FILES_COUNT]);
 
                     $systemErrorsCount += $json[Bridge::SYSTEM_ERRORS_COUNT];
-                    if ($systemErrorsCount >= $systemErrorCountLimit) {
+                    if ($systemErrorsCount >= self::SYSTEM_ERROR_LIMIT) {
                         $reachedInternalErrorsCountLimit = true;
                         $this->processPool->quitAll();
                     }
@@ -220,7 +221,7 @@ function ($exitCode, string $stdErr) use (&$systemErrors, $processIdentifier): v
         if ($reachedSystemErrorsCountLimit) {
             $systemErrors[] = new SystemError(sprintf(
                 'Reached system errors count limit of %d, exiting...',
-                $systemErrorCountLimit
+                self::SYSTEM_ERROR_LIMIT
             ));
         }
 

diff --git a/src/Configuration/Option.php b/src/Configuration/Option.php
@@ -201,11 +201,6 @@ final class Option
      */
     public const PARALLEL_TIMEOUT_IN_SECONDS = 'parallel-timeout-in-seconds';
 
-    /**
-     * @var string
-     */
-    public const PARALLEL_SYSTEM_ERROR_COUNT_LIMIT = 'parallel-system-error-count-limit';
-
     /**
      * @var string
      */