use getType() over getObjectType()

rectorphp · Oct 7, 2021 · a0fbe15 · a0fbe15
1 parent be3d0c6
commit a0fbe15
Show file tree

Hide file tree

Showing 7 changed files with 21 additions and 9 deletions.
diff --git a/rules/CodeQuality/Rector/Identical/FlipTypeControlToUseExclusiveTypeRector.php b/rules/CodeQuality/Rector/Identical/FlipTypeControlToUseExclusiveTypeRector.php
@@ -107,7 +107,7 @@ public function refactor(Node $node): ?Node
         $type = $phpDocInfo->getVarType();
 
         if (! $type instanceof UnionType) {
-            $type = $this->getObjectType($assign->expr);
+            $type = $this->getType($assign->expr);
         }
 
         if (! $type instanceof UnionType) {

diff --git a/rules/CodeQuality/Rector/Isset_/IssetOnPropertyObjectToPropertyExistsRector.php b/rules/CodeQuality/Rector/Isset_/IssetOnPropertyObjectToPropertyExistsRector.php
@@ -95,7 +95,7 @@ public function refactor(Node $node): ?Node
                 continue;
             }
 
-            $propertyFetchVarType = $this->getObjectType($issetVar->var);
+            $propertyFetchVarType = $this->getType($issetVar->var);
 
             if ($propertyFetchVarType instanceof TypeWithClassName) {
                 if (! $this->reflectionProvider->hasClass($propertyFetchVarType->getClassName())) {

diff --git a/rules/CodeQuality/Rector/PropertyFetch/ExplicitMethodCallOverMagicGetSetRector.php b/rules/CodeQuality/Rector/PropertyFetch/ExplicitMethodCallOverMagicGetSetRector.php
@@ -110,7 +110,7 @@ public function refactor(Node $node): ?Node
 
     private function refactorPropertyFetch(PropertyFetch $propertyFetch): MethodCall|null
     {
-        $callerType = $this->getObjectType($propertyFetch->var);
+        $callerType = $this->getType($propertyFetch->var);
         if (! $callerType instanceof TypeWithClassName) {
             return null;
         }
@@ -143,7 +143,7 @@ private function refactorPropertyFetch(PropertyFetch $propertyFetch): MethodCall
 
     private function refactorMagicSet(Expr $expr, PropertyFetch $propertyFetch): MethodCall|null
     {
-        $propertyCallerType = $this->getObjectType($propertyFetch->var);
+        $propertyCallerType = $this->getType($propertyFetch->var);
         if (! $propertyCallerType instanceof ObjectType) {
             return null;
         }

diff --git a/rules/DependencyInjection/Rector/Class_/ActionInjectionToConstructorInjectionRector.php b/rules/DependencyInjection/Rector/Class_/ActionInjectionToConstructorInjectionRector.php
@@ -99,7 +99,7 @@ private function processClassMethod(Class_ $class, ClassMethod $classMethod): vo
                 continue;
             }
 
-            $paramType = $this->getObjectType($paramNode);
+            $paramType = $this->getType($paramNode);
 
             /** @var string $paramName */
             $paramName = $this->getName($paramNode->var);
@@ -124,7 +124,7 @@ private function isActionInjectedParamNode(Param $param): bool
             return false;
         }
 
-        $paramStaticType = $this->getObjectType($param);
+        $paramStaticType = $this->getType($param);
         if (! $paramStaticType instanceof ObjectType) {
             return false;
         }

diff --git a/rules/Php70/Rector/StaticCall/StaticCallOnNonStaticToInstanceCallRector.php b/rules/Php70/Rector/StaticCall/StaticCallOnNonStaticToInstanceCallRector.php
@@ -130,7 +130,7 @@ public function refactor(Node $node): ?Node
     private function resolveStaticCallClassName(StaticCall $staticCall): ?string
     {
         if ($staticCall->class instanceof PropertyFetch) {
-            $objectType = $this->getObjectType($staticCall->class);
+            $objectType = $this->getType($staticCall->class);
             if ($objectType instanceof ObjectType) {
                 return $objectType->getClassName();
             }

diff --git a/rules/Php80/Rector/Class_/ClassPropertyAssignToConstructorPromotionRector.php b/rules/Php80/Rector/Class_/ClassPropertyAssignToConstructorPromotionRector.php
@@ -149,7 +149,7 @@ public function provideMinPhpVersion(): int
     private function processNullableType(Property $property, Param $param): void
     {
         if ($this->nodeTypeResolver->isNullableType($property)) {
-            $objectType = $this->getObjectType($property);
+            $objectType = $this->getType($property);
             $param->type = $this->staticTypeMapper->mapPHPStanTypeToPhpParserNode($objectType, TypeKind::PARAM());
         }
     }

diff --git a/src/Rector/AbstractRector.php b/src/Rector/AbstractRector.php
@@ -323,16 +323,28 @@ protected function isObjectType(Node $node, ObjectType $objectType): bool
         return $this->nodeTypeResolver->isObjectType($node, $objectType);
     }
 
+    /**
+     * @deprecated
+     * Use @see AbstractRector::getType() instead, as single method to get types
+     */
     protected function getStaticType(Node $node): Type
     {
         return $this->nodeTypeResolver->getStaticType($node);
     }
 
     /**
      * @deprecated
-     * Use getStaticType() instead, as single method to get types
+     * Use @see AbstractRector::getType() instead, as single method to get types
      */
     protected function getObjectType(Node $node): Type
+    {
+        return $this->getType($node);
+    }
+
+    /**
+     * Use this method for getting expr|node type
+     */
+    protected function getType(Node $node): Type
     {
         return $this->nodeTypeResolver->resolve($node);
     }