[CodeQuality] Skip non-array type on SimplifyForeachToArrayFilterRect…

…or (#3738)

* [CodeQuality] Skip non-array type on SimplifyForeachToArrayFilterRector

* Fixed 🎉

* eol

* pure check ArrayType

* update to use isArray()->yes() usage

rules-tests/CodeQuality/Rector/Foreach_/SimplifyForeachToArrayFilterRector/Fixture/skip_non_array_type.php.inc

@@ -0,0 +1,25 @@
+<?php
+
+namespace Rector\Tests\CodeQuality\Rector\Foreach_\SimplifyForeachToArrayFilterRector\Fixture;
+
+final class SkipNonArrayType
+{
+    public function __construct(
+        public int $a,
+        public ?int $b
+    ) {
+    }
+
+    public function run()
+    {
+        $a = new SkipNonArrayType(3, null);
+
+        $arr = [];
+        foreach($a as $k => $v) {
+			if($v !== null) {
+				$arr[$k] = $v;
+            }
+        }
+        echo json_encode($arr);
+    }
+}

rules/CodeQuality/Rector/Foreach_/SimplifyForeachToArrayFilterRector.php

@@ -35,7 +35,7 @@ public function __construct(
         private readonly ArrayFilterFactory $arrayFilterFactory,
         private readonly ExprUsedInNodeAnalyzer $exprUsedInNodeAnalyzer,
         private readonly ReadExprAnalyzer $readExprAnalyzer,
-        private readonly PhpVersionProvider $phpVersionProvider,
+        private readonly PhpVersionProvider $phpVersionProvider
     ) {
     }
 
@@ -128,7 +128,12 @@ private function shouldSkip(Foreach_ $foreach): bool
             return true;
         }
 
-        return $ifNode->elseifs !== [];
+        if ($ifNode->elseifs !== []) {
+            return true;
+        }
+
+        $type = $this->getType($foreach->expr);
+        return ! $type->isArray()->yes();
     }
 
     private function shouldSkipForeachKeyUsage(If_ $if, Expr $expr): bool