Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CodeQuality] Skip non-array type on SimplifyForeachToArrayFilterRector #3738

Merged
merged 5 commits into from
May 6, 2023
Merged

[CodeQuality] Skip non-array type on SimplifyForeachToArrayFilterRector #3738

merged 5 commits into from
May 6, 2023

Conversation

samsonasik
Copy link
Member

@samsonasik
Copy link
Member Author

Fixed 🎉 /cc @raoz

@samsonasik
Copy link
Member Author

All checks have passed 🎉 @TomasVotruba I think it is ready.

@samsonasik
Copy link
Member Author

@TomasVotruba I am merging it ;)

@samsonasik samsonasik merged commit a3ea0cf into main May 6, 2023
42 checks passed
@samsonasik samsonasik deleted the skip-non-array-type branch May 6, 2023 11:29
samsonasik added a commit that referenced this pull request May 8, 2023
@samsonasik
[CodeQuality] Skip non-array type on SimplifyForeachToArrayFilterRect…
3166bf2 
…or (#3738)

* [CodeQuality] Skip non-array type on SimplifyForeachToArrayFilterRector

* Fixed 🎉

* eol

* pure check ArrayType

* update to use isArray()->yes() usage
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomasVotruba TomasVotruba Awaiting requested review from TomasVotruba

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@samsonasik