[DeadCode] Skip sub type false => bool on RemoveUselessVarTagRector (#…

…5588)

* [DeadCode] Skip sub type false => bool on RemoveUselessVarTagRector

* [DeadCode] Skip sub type false => bool on RemoveUselessVarTagRector

* [ci-review] Rector Rectify

* remove super type

* more fixture

* Fix

---------

Co-authored-by: GitHub Action <actions@github.com>

rules-tests/DeadCode/Rector/Property/RemoveUselessVarTagRector/Fixture/remove_equal_type.php.inc

@@ -0,0 +1,22 @@
+<?php
+
+namespace Rector\Tests\DeadCode\Rector\Property\RemoveUselessVarTagRector\Fixture;
+
+class RemoveEqualType
+ {
+     /** @var string|false|null */
+     private static string|false|null $inputArgSeparator = null;
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Tests\DeadCode\Rector\Property\RemoveUselessVarTagRector\Fixture;
+
+class RemoveEqualType
+ {
+     private static string|false|null $inputArgSeparator = null;
+}
+
+?>

rules-tests/DeadCode/Rector/Property/RemoveUselessVarTagRector/Fixture/remove_super_type.php.inc

@@ -0,0 +1,22 @@
+<?php
+
+namespace Rector\Tests\DeadCode\Rector\Property\RemoveUselessVarTagRector\Fixture;
+
+class RemoveSuperType
+ {
+     /** @var string|bool|null */
+     private static string|false|null $inputArgSeparator = null;
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Tests\DeadCode\Rector\Property\RemoveUselessVarTagRector\Fixture;
+
+class RemoveSuperType
+ {
+     private static string|false|null $inputArgSeparator = null;
+}
+
+?>

rules-tests/DeadCode/Rector/Property/RemoveUselessVarTagRector/Fixture/skip_sub_type.php.inc

@@ -0,0 +1,9 @@
+<?php
+
+namespace Rector\Tests\DeadCode\Rector\Property\RemoveUselessVarTagRector\Fixture;
+
+class SkipSubType
+ {
+     /** @var string|false|null */
+     private static string|bool|null $inputArgSeparator = null;
+}

src/NodeTypeResolver/TypeComparator/TypeComparator.php

@@ -87,6 +87,10 @@ public function arePhpParserAndPhpStanPhpDocTypesEqual(
             $node
         );
 
+        if (! $this->areTypesEqual($phpParserNodeType, $phpStanDocType) && $this->isSubtype($phpStanDocType, $phpParserNodeType)) {
+            return false;
+        }
+
         // normalize bool union types
         $phpParserNodeType = $this->normalizeConstantBooleanType($phpParserNodeType);
         $phpStanDocType = $this->normalizeConstantBooleanType($phpStanDocType);