[Php81] Skip possible array on NullToStrictStringFuncCallArgRector (#…

…5587) * [Php81] Skip possible array on NullToStrictStringFuncCallArgRector * [Php81] Skip possible array on NullToStrictStringFuncCallArgRector
rectorphp · Feb 8, 2024 · 178ce5c · 178ce5c
1 parent 2194c6e
commit 178ce5c
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/...1/Rector/FuncCall/NullToStrictStringFuncCallArgRector/Fixture/skip_possible_array.php.inc b/...1/Rector/FuncCall/NullToStrictStringFuncCallArgRector/Fixture/skip_possible_array.php.inc
@@ -0,0 +1,11 @@
+<?php
+
+namespace Rector\Tests\Php81\Rector\FuncCall\NullToStrictStringFuncCallArgRector\Fixture;
+
+final class SkipPossibleArray
+{
+    public function run(string|array|null $value): array|string
+    {
+        return str_replace('for', 'bar', $value);
+    }
+}
diff --git a/rules/Php81/Rector/FuncCall/NullToStrictStringFuncCallArgRector.php b/rules/Php81/Rector/FuncCall/NullToStrictStringFuncCallArgRector.php
@@ -219,7 +219,7 @@ private function shouldSkipType(Type $type): bool
     {
         return ! $type instanceof MixedType &&
             ! $type instanceof NullType &&
-            ! ($type instanceof UnionType && $this->unionTypeAnalyzer->isNullable($type));
+            ! ($type instanceof UnionType && $this->unionTypeAnalyzer->isNullable($type, true));
     }
 
     private function shouldSkipTrait(Expr $expr, Type $type, bool $isTrait): bool