Remove extends tempalte check, to avoid missing scope bugs (#1096)

rectorphp · Oct 28, 2021 · a5f8d52 · a5f8d52
1 parent 849ed2f
commit a5f8d52
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 79 deletions.
diff --git a/packages/NodeTypeResolver/PHPStan/CollisionGuard/TemplateExtendsGuard.php b/packages/NodeTypeResolver/PHPStan/CollisionGuard/TemplateExtendsGuard.php
diff --git a/packages/NodeTypeResolver/PHPStan/Scope/PHPStanNodeScopeResolver.php b/packages/NodeTypeResolver/PHPStan/Scope/PHPStanNodeScopeResolver.php
@@ -29,7 +29,6 @@
 use Rector\Core\Stubs\DummyTraitClass;
 use Rector\NodeTypeResolver\Node\AttributeKey;
 use Rector\NodeTypeResolver\PHPStan\CollisionGuard\MixinGuard;
-use Rector\NodeTypeResolver\PHPStan\CollisionGuard\TemplateExtendsGuard;
 use Rector\NodeTypeResolver\PHPStan\Scope\NodeVisitor\RemoveDeepChainMethodCallNodeVisitor;
 use Symplify\PackageBuilder\Reflection\PrivatesAccessor;
 use Symplify\SmartFileSystem\SmartFileInfo;
@@ -63,7 +62,6 @@ public function __construct(
         private PrivatesAccessor $privatesAccessor,
         private RenamedClassesSourceLocator $renamedClassesSourceLocator,
         private ParentAttributeSourceLocator $parentAttributeSourceLocator,
-        private TemplateExtendsGuard $templateExtendsGuard,
         private MixinGuard $mixinGuard,
     ) {
     }
@@ -114,12 +112,6 @@ public function processNodes(array $stmts, SmartFileInfo $smartFileInfo): array
 
         $this->decoratePHPStanNodeScopeResolverWithRenamedClassSourceLocator($this->nodeScopeResolver);
 
-        // it needs to be checked early before `@mixin` check as
-        // ReflectionProvider already hang when check class with `@template-extends`
-        if ($this->templateExtendsGuard->containsTemplateExtendsPhpDoc($stmts, $smartFileInfo->getFilename())) {
-            return $stmts;
-        }
-
         return $this->processNodesWithMixinHandling($smartFileInfo, $stmts, $scope, $nodeCallback);
     }