[TypeDeclaration] Deprecate TypedPropertyFromStrictGetterMethodReturn…

…TypeRector as depends on missing context and creates invalid code (#5269)
rectorphp · Nov 21, 2023 · a9797fd · a9797fd
1 parent b5f7a09
commit a9797fd
Show file tree

Hide file tree

Showing 23 changed files with 13 additions and 688 deletions.
diff --git a/config/set/type-declaration.php b/config/set/type-declaration.php
@@ -36,7 +36,6 @@
 use Rector\TypeDeclaration\Rector\Param\ParamTypeFromStrictTypedPropertyRector;
 use Rector\TypeDeclaration\Rector\Property\TypedPropertyFromAssignsRector;
 use Rector\TypeDeclaration\Rector\Property\TypedPropertyFromStrictConstructorRector;
-use Rector\TypeDeclaration\Rector\Property\TypedPropertyFromStrictGetterMethodReturnTypeRector;
 use Rector\TypeDeclaration\Rector\Property\TypedPropertyFromStrictSetUpRector;
 
 return static function (RectorConfig $rectorConfig): void {
@@ -51,7 +50,6 @@
         AddVoidReturnTypeWhereNoReturnRector::class,
         ReturnTypeFromStrictFluentReturnRector::class,
         ReturnTypeFromReturnNewRector::class,
-        TypedPropertyFromStrictGetterMethodReturnTypeRector::class,
         AddMethodCallBasedStrictParamTypeRector::class,
         ReturnTypeFromStrictBoolReturnExprRector::class,
         ReturnTypeFromStrictNativeCallRector::class,

diff --git a/phpstan.neon b/phpstan.neon
@@ -538,3 +538,7 @@ parameters:
         -
             path: rules/Transform/Rector/Attribute/AttributeKeyToClassConstFetchRector.php
             message: "#Method \"processToClassConstFetch\\(\\)\" returns bool type, so the name should start with is/has/was#"
+
+        # deprecated code
+        - '#Class "Rector\\TypeDeclaration\\Rector\\Property\\TypedPropertyFromStrictGetterMethodReturnTypeRector" is missing @see annotation with test case class reference#'
+        - '#Fetching class constant class of deprecated class Rector\\TypeDeclaration\\Rector\\Property\\TypedPropertyFromStrictGetterMethodReturnTypeRector#'
diff --git a/...TypedPropertyFromStrictGetterMethodReturnTypeRector/Fixture/assigned_in_construct.php.inc b/...TypedPropertyFromStrictGetterMethodReturnTypeRector/Fixture/assigned_in_construct.php.inc
diff --git a/...erty/TypedPropertyFromStrictGetterMethodReturnTypeRector/Fixture/private_property.php.inc b/...erty/TypedPropertyFromStrictGetterMethodReturnTypeRector/Fixture/private_property.php.inc
diff --git a/...yFromStrictGetterMethodReturnTypeRector/Fixture/private_property_with_single_type.php.inc b/...yFromStrictGetterMethodReturnTypeRector/Fixture/private_property_with_single_type.php.inc
diff --git a/...yFromStrictGetterMethodReturnTypeRector/Fixture/public_property_with_null_default.php.inc b/...yFromStrictGetterMethodReturnTypeRector/Fixture/public_property_with_null_default.php.inc
diff --git a/...ty/TypedPropertyFromStrictGetterMethodReturnTypeRector/Fixture/skip_default_value.php.inc b/...ty/TypedPropertyFromStrictGetterMethodReturnTypeRector/Fixture/skip_default_value.php.inc
diff --git a/...roperty/TypedPropertyFromStrictGetterMethodReturnTypeRector/Fixture/skip_doc_type.php.inc b/...roperty/TypedPropertyFromStrictGetterMethodReturnTypeRector/Fixture/skip_doc_type.php.inc
diff --git a/...rty/TypedPropertyFromStrictGetterMethodReturnTypeRector/Fixture/skip_parent_guard.php.inc b/...rty/TypedPropertyFromStrictGetterMethodReturnTypeRector/Fixture/skip_parent_guard.php.inc
diff --git a/...Property/TypedPropertyFromStrictGetterMethodReturnTypeRector/Fixture/some_fixture.php.inc b/...Property/TypedPropertyFromStrictGetterMethodReturnTypeRector/Fixture/some_fixture.php.inc
diff --git a/...or/Property/TypedPropertyFromStrictGetterMethodReturnTypeRector/Fixture/some_self.php.inc b/...or/Property/TypedPropertyFromStrictGetterMethodReturnTypeRector/Fixture/some_self.php.inc
diff --git a/...operty/TypedPropertyFromStrictGetterMethodReturnTypeRector/Source/ParentClassWithName.php b/...operty/TypedPropertyFromStrictGetterMethodReturnTypeRector/Source/ParentClassWithName.php
diff --git a/...tGetterMethodReturnTypeRector/TypedPropertyFromStrictGetterMethodReturnTypeRectorTest.php b/...tGetterMethodReturnTypeRector/TypedPropertyFromStrictGetterMethodReturnTypeRectorTest.php
diff --git a/...r/Property/TypedPropertyFromStrictGetterMethodReturnTypeRector/config/configured_rule.php b/...r/Property/TypedPropertyFromStrictGetterMethodReturnTypeRector/config/configured_rule.php