[CodeQuality] Fix array_keys on object in UnusedForeachValueToArrayKe…

…ysRector (#411)

rules-tests/CodeQuality/Rector/Foreach_/UnusedForeachValueToArrayKeysRector/Fixture/fixture.php.inc

@@ -4,7 +4,7 @@ namespace Rector\Tests\CodeQuality\Rector\Foreach_\UnusedForeachValueToArrayKeys
 
 class Fixture
 {
-    public function run($values)
+    public function run(array $values)
     {
         $items = [];
         foreach ($values as $key => $value) {
@@ -21,7 +21,7 @@ namespace Rector\Tests\CodeQuality\Rector\Foreach_\UnusedForeachValueToArrayKeys
 
 class Fixture
 {
-    public function run($values)
+    public function run(array $values)
     {
         $items = [];
         foreach (array_keys($values) as $key) {

rules-tests/CodeQuality/Rector/Foreach_/UnusedForeachValueToArrayKeysRector/Fixture/skip_array_access_object.php.inc

@@ -0,0 +1,22 @@
+<?php
+
+namespace Rector\Tests\CodeQuality\Rector\Foreach_\UnusedForeachValueToArrayKeysRector\Fixture;
+
+use PhpCsFixer\Doctrine\Annotation\Token;
+use PhpCsFixer\Doctrine\Annotation\Tokens;
+
+final class SkipArrayAccessObject
+{
+    /**
+     * @param Tokens<Token> $tokens
+     */
+    public function run(Tokens $tokens)
+    {
+        $indexes = [];
+        foreach ($tokens as $index => $token) {
+            $indexes[] = $index;
+        }
+
+        return $indexes;
+    }
+}

rules/CodeQuality/Rector/Foreach_/UnusedForeachValueToArrayKeysRector.php

@@ -5,6 +5,7 @@
 namespace Rector\CodeQuality\Rector\Foreach_;
 
 use PhpParser\Node;
+use PhpParser\Node\Expr;
 use PhpParser\Node\Expr\Array_;
 use PhpParser\Node\Expr\ArrayItem;
 use PhpParser\Node\Expr\FuncCall;
@@ -93,8 +94,7 @@ public function refactor(Node $node): ?Node
             return null;
         }
 
-        $exprType = $this->getStaticType($node->expr);
-        if ($exprType instanceof ObjectType) {
+        if (! $this->isArrayType($node->expr)) {
             return null;
         }
 
@@ -152,4 +152,14 @@ private function removeForeachValueAndUseArrayKeys(Foreach_ $foreach): void
 
         $foreach->expr = $this->nodeFactory->createFuncCall('array_keys', [$foreach->expr]);
     }
+
+    private function isArrayType(Expr $expr): bool
+    {
+        $exprType = $this->getStaticType($expr);
+        if ($exprType instanceof ObjectType) {
+            return false;
+        }
+
+        return $exprType->isArray()->yes();
+    }
 }