Fix SingleInArrayToCompareRector if array item is variadic (#3640)

* Add failing test fixture for SingleInArrayToCompareRector Based on https://getrector.com/demo/001ae62c-7857-4ce2-b4c1-8be77fd37568 * fix SingleInArrayToCompareRector in case the array item is variadic * rename SingleInArrayToCompareRector unpacking fixture as suggested by @samsonasik
rectorphp · Apr 21, 2023 · add5582 · add5582
1 parent ae99f13
commit add5582
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 0 deletions.
diff --git a/...ector/FuncCall/SingleInArrayToCompareRector/Fixture/skip_unpack_array_item_exists.php.inc b/...ector/FuncCall/SingleInArrayToCompareRector/Fixture/skip_unpack_array_item_exists.php.inc
@@ -0,0 +1,12 @@
+<?php
+
+namespace Rector\Tests\CodeQuality\Rector\FuncCall\SingleInArrayToCompareRector\Fixture;
+
+final class SkipUnpackArrayItemExists
+{
+    public function run()
+    {
+        $a = ['a', 'b'];
+        echo in_array('a', [...$a]);
+    }
+}
diff --git a/rules/CodeQuality/Rector/FuncCall/SingleInArrayToCompareRector.php b/rules/CodeQuality/Rector/FuncCall/SingleInArrayToCompareRector.php
@@ -94,6 +94,10 @@ public function refactor(Node $node): ?Node
             return null;
         }
 
+        if($firstArrayItem->unpack){
+            return null;
+        }
+
         if (! isset($node->args[0])) {
             return null;
         }