avoid future getArgs() method that breaks package usage

rectorphp · Oct 27, 2021 · adff549 · adff549
1 parent a9710ac
commit adff549
Showing 1 changed file with 11 additions and 3 deletions.
diff --git a/rules/Php73/Rector/FuncCall/JsonThrowOnErrorRector.php b/rules/Php73/Rector/FuncCall/JsonThrowOnErrorRector.php
@@ -83,14 +83,22 @@ private function shouldSkip(FuncCall $funcCall): bool
             return true;
         }
 
-        $args = $funcCall->getArgs();
-        foreach ($args as $arg) {
+        if ($funcCall->args === null) {
+            return true;
+        }
+
+        foreach ($funcCall->args as $arg) {
+            if (! $arg instanceof Arg) {
+                continue;
+            }
+
             if ($arg->name instanceof Identifier) {
                 return true;
             }
         }
 
-        $value = $this->valueResolver->getValue($args[0]->value);
+        $firstArg = $funcCall->args[0];
+        $value = $this->valueResolver->getValue($firstArg->value);
         if (is_string($value)) {
             return true;
         }