[TypeDeclaration] Keep constant false return type from strict native …

…call (#5223)

packages/NodeTypeResolver/PHPStan/Type/TypeFactory.php

@@ -56,16 +56,30 @@ public function createMixedPassedOrUnionType(array $types, bool $keepConstantTyp
      */
     public function uniquateTypes(array $types, bool $keepConstant = false): array
     {
+        $constantTypeHashes = [];
         $uniqueTypes = [];
+
         foreach ($types as $type) {
-            if (! $keepConstant) {
-                $type = $this->removeValueFromConstantType($type);
+            $removedConstantType = $this->removeValueFromConstantType($type);
+            $removedConstantTypeHash = $this->typeHasher->createTypeHash($removedConstantType);
+
+            if ($keepConstant && $type !== $removedConstantType) {
+                $typeHash = $this->typeHasher->createTypeHash($type);
+                $constantTypeHashes[$typeHash] = $removedConstantTypeHash;
+            } else {
+                $type = $removedConstantType;
+                $typeHash = $removedConstantTypeHash;
             }
 
-            $typeHash = $this->typeHasher->createTypeHash($type);
             $uniqueTypes[$typeHash] = $type;
         }
 
+        foreach ($constantTypeHashes as $constantTypeHash => $removedConstantTypeHash) {
+            if (array_key_exists($removedConstantTypeHash, $uniqueTypes)) {
+                unset($uniqueTypes[$constantTypeHash]);
+            }
+        }
+
         // re-index
         return array_values($uniqueTypes);
     }

rules-tests/TypeDeclaration/Rector/ClassMethod/ReturnTypeFromStrictNativeCallRector/Fixture/native_method_call_returning_boolean_or_union_false.php.inc

@@ -0,0 +1,35 @@
+<?php
+
+namespace Rector\Tests\TypeDeclaration\Rector\ClassMethod\ReturnTypeFromStrictNativeCallRector\Fixture;
+
+final class NativeMethodCallReturningBooleanUnionFalse
+{
+    public function run(string $needle, array $haystack)
+    {
+        if (rand(0,1)) {
+            return in_array($needle, $haystack, true);
+        }
+
+        return ob_get_clean();
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Tests\TypeDeclaration\Rector\ClassMethod\ReturnTypeFromStrictNativeCallRector\Fixture;
+
+final class NativeMethodCallReturningBooleanUnionFalse
+{
+    public function run(string $needle, array $haystack): bool|string
+    {
+        if (rand(0,1)) {
+            return in_array($needle, $haystack, true);
+        }
+
+        return ob_get_clean();
+    }
+}
+
+?>

rules-tests/TypeDeclaration/Rector/ClassMethod/ReturnTypeFromStrictNativeCallRector/Fixture/native_method_call_returning_union.php.inc

@@ -0,0 +1,27 @@
+<?php
+
+namespace Rector\Tests\TypeDeclaration\Rector\ClassMethod\ReturnTypeFromStrictNativeCallRector\Fixture;
+
+final class NativeMethodCallReturningUnion
+{
+    public function run()
+    {
+        return time_nanosleep(100, 100);
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Tests\TypeDeclaration\Rector\ClassMethod\ReturnTypeFromStrictNativeCallRector\Fixture;
+
+final class NativeMethodCallReturningUnion
+{
+    public function run(): array|bool
+    {
+        return time_nanosleep(100, 100);
+    }
+}
+
+?>

rules-tests/TypeDeclaration/Rector/ClassMethod/ReturnTypeFromStrictNativeCallRector/Fixture/native_method_call_returning_union_false.php.inc

@@ -0,0 +1,27 @@
+<?php
+
+namespace Rector\Tests\TypeDeclaration\Rector\ClassMethod\ReturnTypeFromStrictNativeCallRector\Fixture;
+
+final class NativeMethodCallReturningUnionFalse
+{
+    public function run()
+    {
+        return ob_get_clean();
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Tests\TypeDeclaration\Rector\ClassMethod\ReturnTypeFromStrictNativeCallRector\Fixture;
+
+final class NativeMethodCallReturningUnionFalse
+{
+    public function run(): string|false
+    {
+        return ob_get_clean();
+    }
+}
+
+?>

rules-tests/TypeDeclaration/Rector/ClassMethod/ReturnTypeFromStrictNativeCallRector/Fixture/native_method_call_returning_union_false_or_boolean.php.inc

@@ -0,0 +1,35 @@
+<?php
+
+namespace Rector\Tests\TypeDeclaration\Rector\ClassMethod\ReturnTypeFromStrictNativeCallRector\Fixture;
+
+final class NativeMethodCallReturningMergedUnionFalseOrBoolean
+{
+    public function run(string $needle, array $haystack)
+    {
+        if (rand(0,1)) {
+            return ob_get_clean();
+        }
+
+        return in_array($needle, $haystack, true);
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Tests\TypeDeclaration\Rector\ClassMethod\ReturnTypeFromStrictNativeCallRector\Fixture;
+
+final class NativeMethodCallReturningMergedUnionFalseOrBoolean
+{
+    public function run(string $needle, array $haystack): string|bool
+    {
+        if (rand(0,1)) {
+            return ob_get_clean();
+        }
+
+        return in_array($needle, $haystack, true);
+    }
+}
+
+?>

rules/TypeDeclaration/Rector/ClassMethod/ReturnTypeFromStrictNativeCallRector.php

@@ -96,7 +96,7 @@ public function refactorWithScope(Node $node, Scope $scope): ?Node
             $callLikeTypes[] = $this->getType($nativeCallLike);
         }
 
-        $returnType = $this->typeFactory->createMixedPassedOrUnionType($callLikeTypes);
+        $returnType = $this->typeFactory->createMixedPassedOrUnionTypeAndKeepConstant($callLikeTypes);
         if ($returnType instanceof MixedType) {
             return null;
         }