[Php80] Skip PDO::query() on AddParamBasedOnParentClassMethodRector (#…

…5313)

rules-tests/Php80/Rector/ClassMethod/AddParamBasedOnParentClassMethodRector/Fixture/skip_extends_pdo_query.php.inc

@@ -0,0 +1,10 @@
+<?php
+
+namespace Rector\Tests\Php80\Rector\ClassMethod\AddParamBasedOnParentClassMethodRector\Fixture;
+
+class SkipExtendsPDOQuery extends \PDO {
+    public function query() {
+        $args = func_get_args();
+        return parent::query($args[0]);
+    }
+}

rules/Php80/Rector/ClassMethod/AddParamBasedOnParentClassMethodRector.php

@@ -13,11 +13,13 @@
 use PhpParser\Node\Name;
 use PhpParser\Node\Param;
 use PhpParser\Node\Stmt\ClassMethod;
+use PHPStan\Reflection\ClassReflection;
 use PHPStan\Reflection\MethodReflection;
 use Rector\Core\PhpParser\AstResolver;
 use Rector\Core\PhpParser\Node\BetterNodeFinder;
 use Rector\Core\PhpParser\Printer\BetterStandardPrinter;
 use Rector\Core\Rector\AbstractRector;
+use Rector\Core\Reflection\ReflectionResolver;
 use Rector\Core\ValueObject\MethodName;
 use Rector\Core\ValueObject\PhpVersionFeature;
 use Rector\NodeTypeResolver\Node\AttributeKey;
@@ -37,6 +39,7 @@ public function __construct(
         private readonly AstResolver $astResolver,
         private readonly BetterStandardPrinter $betterStandardPrinter,
         private readonly BetterNodeFinder $betterNodeFinder,
+        private readonly ReflectionResolver $reflectionResolver
     ) {
     }
 
@@ -109,6 +112,15 @@ public function refactor(Node $node): ?Node
             return null;
         }
 
+        $currentClassReflection = $this->reflectionResolver->resolveClassReflection($node);
+        $isPDO = $currentClassReflection instanceof  ClassReflection && $currentClassReflection->isSubclassOf('PDO');
+
+        // It relies on phpstorm stubs that define 2 kind of query method for both php 7.4 and php 8.0
+        // @see https://github.com/JetBrains/phpstorm-stubs/blob/e2e898a29929d2f520fe95bdb2109d8fa895ba4a/PDO/PDO.php#L1096-L1126
+        if ($isPDO && $parentMethodReflection->getName() === 'query') {
+            return null;
+        }
+
         $parentClassMethod = $this->astResolver->resolveClassMethodFromMethodReflection($parentMethodReflection);
         if (! $parentClassMethod instanceof ClassMethod) {
             return null;