[DX] Use directly instanceof (#3021)

rectorphp · Oct 28, 2022 · af4cf28 · af4cf28
1 parent 81d79a8
commit af4cf28
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/rules/CodeQuality/Rector/If_/SimplifyIfNotNullReturnRector.php b/rules/CodeQuality/Rector/If_/SimplifyIfNotNullReturnRector.php
@@ -5,6 +5,7 @@
 namespace Rector\CodeQuality\Rector\If_;
 
 use PhpParser\Node;
+use PhpParser\Node\Expr;
 use PhpParser\Node\Stmt;
 use PhpParser\Node\Stmt\If_;
 use PhpParser\Node\Stmt\Return_;
@@ -62,7 +63,7 @@ public function getNodeTypes(): array
     public function refactor(Node $node): ?Stmt
     {
         $expr = $this->ifManipulator->matchIfNotNullReturnValue($node);
-        if ($expr !== null) {
+        if ($expr instanceof Expr) {
             $insideIfNode = $node->stmts[0];
 
             $nextNode = $node->getAttribute(AttributeKey::NEXT_NODE);

diff --git a/rules/Transform/NodeAnalyzer/FuncCallStaticCallToMethodCallAnalyzer.php b/rules/Transform/NodeAnalyzer/FuncCallStaticCallToMethodCallAnalyzer.php
@@ -4,6 +4,7 @@
 
 namespace Rector\Transform\NodeAnalyzer;
 
+use PhpParser\Node\Expr;
 use PhpParser\Node\Expr\MethodCall;
 use PhpParser\Node\Expr\PropertyFetch;
 use PhpParser\Node\Expr\Variable;
@@ -42,7 +43,7 @@ public function matchTypeProvidingExpr(
             $objectType
         );
 
-        if ($expr !== null) {
+        if ($expr instanceof Expr) {
             if ($expr instanceof Variable) {
                 $this->addClassMethodParamForVariable($expr, $objectType, $classMethod);
             }