[DeadCode] Skip assign inside if cond on RemoveAlwaysTrueIfConditionR…

…ector (#3447)

Co-authored-by: Naugrimm <Naugrimm@users.noreply.github.com>

rules-tests/DeadCode/Rector/If_/RemoveAlwaysTrueIfConditionRector/Fixture/skip_assign_in_if_cond.php.inc

@@ -0,0 +1,13 @@
+<?php
+
+namespace Rector\Tests\DeadCode\Rector\If_\RemoveAlwaysTrueIfConditionRector\Fixture;
+
+final class SkipAssignInIfCond
+{
+    public function run()
+    {
+        if (($value = "foo") !== null) {
+        	echo $value;
+        }
+    }
+}

rules/DeadCode/Rector/If_/RemoveAlwaysTrueIfConditionRector.php

@@ -6,6 +6,7 @@
 
 use PhpParser\Node;
 use PhpParser\Node\Expr;
+use PhpParser\Node\Expr\Assign;
 use PhpParser\Node\Expr\PropertyFetch;
 use PhpParser\Node\Expr\StaticPropertyFetch;
 use PhpParser\Node\Expr\Variable;
@@ -103,6 +104,11 @@ public function refactor(Node $node): If_|null|array
             return null;
         }
 
+        $hasAssign = (bool) $this->betterNodeFinder->findFirstInstanceOf($node->cond, Assign::class);
+        if ($hasAssign) {
+            return null;
+        }
+
         if ($node->stmts === []) {
             $this->removeNode($node);
             return null;