[DX] Cleanup, Remove RepeatedLiteralToClassConstantRector, as very na…

…rrow use case; use rather phpstan + Remove ChangeLocalPropertyToVariableRector, as buggy and unreliable; better use PHPStan (#2686)

config/set/code-quality.php

@@ -10,6 +10,7 @@
 use Rector\CodeQuality\Rector\BooleanNot\SimplifyDeMorganBinaryRector;
 use Rector\CodeQuality\Rector\Catch_\ThrowWithPreviousExceptionRector;
 use Rector\CodeQuality\Rector\Class_\CompleteDynamicPropertiesRector;
+use Rector\CodeQuality\Rector\Class_\InlineConstructorDefaultToPropertyRector;
 use Rector\CodeQuality\Rector\ClassMethod\InlineArrayReturnAssignRector;
 use Rector\CodeQuality\Rector\ClassMethod\NarrowUnionTypeDocRector;
 use Rector\CodeQuality\Rector\Concat\JoinStringConcatRector;
@@ -182,5 +183,6 @@
         InlineArrayReturnAssignRector::class,
         InlineIsAInstanceOfRector::class,
         TernaryFalseExpressionToIfRector::class,
+        InlineConstructorDefaultToPropertyRector::class,
     ]);
 };

config/set/coding-style.php

@@ -17,8 +17,10 @@
 use Rector\CodingStyle\Rector\Encapsed\EncapsedStringsToSprintfRector;
 use Rector\CodingStyle\Rector\Encapsed\WrapEncapsedVariableInCurlyBracesRector;
 use Rector\CodingStyle\Rector\FuncCall\CallUserFuncArrayToVariadicRector;
+use Rector\CodingStyle\Rector\FuncCall\CallUserFuncToMethodCallRector;
 use Rector\CodingStyle\Rector\FuncCall\ConsistentImplodeRector;
 use Rector\CodingStyle\Rector\FuncCall\ConsistentPregDelimiterRector;
+use Rector\CodingStyle\Rector\FuncCall\CountArrayToEmptyArrayComparisonRector;
 use Rector\CodingStyle\Rector\FuncCall\VersionCompareFuncCallToConstantRector;
 use Rector\CodingStyle\Rector\If_\NullableCompareToNullRector;
 use Rector\CodingStyle\Rector\Plus\UseIncrementAssignRector;
@@ -69,5 +71,7 @@
         VersionCompareFuncCallToConstantRector::class,
         StaticArrowFunctionRector::class,
         StaticClosureRector::class,
+        CountArrayToEmptyArrayComparisonRector::class,
+        CallUserFuncToMethodCallRector::class,
     ]);
 };

config/set/privatization.php

@@ -4,10 +4,8 @@
 
 use Rector\Config\RectorConfig;
 use Rector\Privatization\Rector\Class_\ChangeGlobalVariablesToPropertiesRector;
-use Rector\Privatization\Rector\Class_\ChangeLocalPropertyToVariableRector;
 use Rector\Privatization\Rector\Class_\ChangeReadOnlyVariableWithDefaultValueToConstantRector;
 use Rector\Privatization\Rector\Class_\FinalizeClassesWithoutChildrenRector;
-use Rector\Privatization\Rector\Class_\RepeatedLiteralToClassConstantRector;
 use Rector\Privatization\Rector\ClassMethod\PrivatizeFinalClassMethodRector;
 use Rector\Privatization\Rector\MethodCall\PrivatizeLocalGetterToPropertyRector;
 use Rector\Privatization\Rector\Property\ChangeReadOnlyPropertyWithDefaultValueToConstantRector;
@@ -18,11 +16,7 @@
     $rectorConfig->rule(ChangeGlobalVariablesToPropertiesRector::class);
     $rectorConfig->rule(ChangeReadOnlyPropertyWithDefaultValueToConstantRector::class);
     $rectorConfig->rule(ChangeReadOnlyVariableWithDefaultValueToConstantRector::class);
-    $rectorConfig->rule(RepeatedLiteralToClassConstantRector::class);
     $rectorConfig->rule(PrivatizeLocalGetterToPropertyRector::class);
     $rectorConfig->rule(PrivatizeFinalClassPropertyRector::class);
     $rectorConfig->rule(PrivatizeFinalClassMethodRector::class);
-
-    // buggy, requires more work
-    // $services->set(ChangeLocalPropertyToVariableRector::class);
 };

packages/Set/ValueObject/SetList.php

@@ -34,7 +34,7 @@ final class SetList implements SetListInterface
     /**
      * @var string
      */
-    public const GMAGICK_TO_IMAGICK = __DIR__ . '/../../../config/set/gmagick_to_imagick.php';
+    public const GMAGICK_TO_IMAGICK = __DIR__ . '/../../../config/set/gmagick-to-imagick.php';
 
     /**
      * @var string