Incorrect behavior of RemoveUnusedPrivateMethodRector (#227)

rectorphp · Jun 15, 2021 · bad9871 · bad9871
1 parent b44261f
commit bad9871
Show file tree

Hide file tree

Showing 2 changed files with 27 additions and 1 deletion.
diff --git a/packages/NodeCollector/NodeCollector/NodeRepository.php b/packages/NodeCollector/NodeCollector/NodeRepository.php
@@ -471,7 +471,7 @@ private function collectArray(Array_ $array): void
             return;
         }
 
-        $this->arrayCallablesByTypeAndMethod[$arrayCallable->getClass()][$arrayCallable->getMethod()][] = $arrayCallable;
+        $this->arrayCallablesByTypeAndMethod[$arrayCallable->getClass()][strtolower($arrayCallable->getMethod())][] = $arrayCallable;
     }
 
     private function addMethod(ClassMethod $classMethod): void

diff --git a/...rivateMethodRector/Fixture/skip_array_callables_this_case_insensitive_method_name.php.inc b/...rivateMethodRector/Fixture/skip_array_callables_this_case_insensitive_method_name.php.inc
@@ -0,0 +1,26 @@
+<?php
+
+namespace Rector\Tests\DeadCode\Rector\ClassMethod\RemoveUnusedPrivateMethodRector\Fixture;
+
+final class SkipArrayCallablesThisCaseInsensitiveMethodName
+{
+    public function run()
+    {
+        $array  = [3, 2, 1];
+
+        usort($array, [$this, 'sortCamelCasedMethodName']);
+        usort($array, [$this, 'sortCaseInSensitiveMETHODName']);
+
+        return $array;
+    }
+
+    private function sortCamelCasedMethodName($a, $b)
+    {
+        return $a <=> $b;
+    }
+
+    private function SOrtCAseINSENsitivEMEthodnaME($a, $b)
+    {
+        return $a <=> $b;
+    }
+}