Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect behavior of RemoveUnusedPrivateMethodRector #227

Merged
merged 1 commit into from
Jun 15, 2021

Conversation

tugmaks
Copy link
Contributor

@tugmaks tugmaks commented Jun 15, 2021

@samsonasik
Copy link
Member

samsonasik commented Jun 15, 2021

Please add 1 more test case for case insensitive:

final class SkipArrayCallablesThisCaseInSensitiveMethodName
 {
     public function run()
     {
         $array  = [3, 2, 1];

         usort($array, [$this, 'sortCaseInSensitiveMethodName']);

         return $array;
     }

     private function sortCaseInSensitiveMETHODName($a, $b)
     {
         return $a <=> $b;
     }
 }

@samsonasik
Copy link
Member

We need insencitive case one, which I tried your patch locally with insensitive "sortCaseInSensitiveMETHODName" and got failure.

@tugmaks
Copy link
Contributor Author

tugmaks commented Jun 15, 2021

@samsonasik done

@TomasVotruba TomasVotruba merged commit bad9871 into rectorphp:main Jun 15, 2021
@TomasVotruba
Copy link
Member

Thank you

@tugmaks tugmaks deleted the bug-6507 branch June 16, 2021 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants