[Renaming] Deprecate PseudoNamespaceToNamespaceRector as too dynamic …

…and unreliable, use the RenameClassRector instead (#4755)
rectorphp · Aug 10, 2023 · bcb51e8 · bcb51e8
1 parent f294e6d
commit bcb51e8
Show file tree

Hide file tree

Showing 23 changed files with 16 additions and 609 deletions.
diff --git a/composer.json b/composer.json
@@ -107,8 +107,7 @@
         "classmap": [
             "stubs",
             "rules-tests/CodingStyle/Rector/Namespace_/ImportFullyQualifiedNamesRector/Source",
-            "rules-tests/Renaming/Rector/Name/RenameClassRector/Source",
-            "rules-tests/Renaming/Rector/FileWithoutNamespace/PseudoNamespaceToNamespaceRector/Source"
+            "rules-tests/Renaming/Rector/Name/RenameClassRector/Source"
         ],
         "files": [
             "stubs/Directory.php",

diff --git a/config/config.php b/config/config.php
@@ -125,7 +125,6 @@
 
             __DIR__ . '/../packages/PHPStanStaticTypeMapper/Enum',
             __DIR__ . '/../packages/Caching/Cache.php',
-            __DIR__ . '/../packages/NodeTypeResolver/PhpDocNodeVisitor/UnderscoreRenamePhpDocNodeVisitor.php',
             __DIR__ . '/../packages/NodeTypeResolver/PHPStan/ObjectWithoutClassTypeWithParentTypes.php',
 
             // used in PHPStan

diff --git a/packages/NodeTypeResolver/PhpDoc/PhpDocTypeRenamer.php b/packages/NodeTypeResolver/PhpDoc/PhpDocTypeRenamer.php
diff --git a/packages/NodeTypeResolver/PhpDocNodeVisitor/UnderscoreRenamePhpDocNodeVisitor.php b/packages/NodeTypeResolver/PhpDocNodeVisitor/UnderscoreRenamePhpDocNodeVisitor.php
diff --git a/phpstan.neon b/phpstan.neon
@@ -711,3 +711,6 @@ parameters:
 
         # not practical
         - '#Use separate function calls with readable variable names#'
+
+        # deprecated
+        - '#Class "Rector\\Renaming\\Rector\\FileWithoutNamespace\\PseudoNamespaceToNamespaceRector" is missing @see annotation with test case class reference#'
diff --git a/.../PseudoNamespaceToNamespaceRector/Fixture/namespace_split_from_underscored_classs.php.inc b/.../PseudoNamespaceToNamespaceRector/Fixture/namespace_split_from_underscored_classs.php.inc
diff --git a/...ctor/FileWithoutNamespace/PseudoNamespaceToNamespaceRector/Fixture/phpunit_rename.php.inc b/...ctor/FileWithoutNamespace/PseudoNamespaceToNamespaceRector/Fixture/phpunit_rename.php.inc
diff --git a/...leWithoutNamespace/PseudoNamespaceToNamespaceRector/Fixture/phpunit_special_class.php.inc b/...leWithoutNamespace/PseudoNamespaceToNamespaceRector/Fixture/phpunit_special_class.php.inc
diff --git a/...WithoutNamespace/PseudoNamespaceToNamespaceRector/Fixture/phpunit_test_case_split.php.inc b/...WithoutNamespace/PseudoNamespaceToNamespaceRector/Fixture/phpunit_test_case_split.php.inc
diff --git a/...Namespace/PseudoNamespaceToNamespaceRector/Fixture/skip_class_from_same_namespace.php.inc b/...Namespace/PseudoNamespaceToNamespaceRector/Fixture/skip_class_from_same_namespace.php.inc
diff --git a/...leWithoutNamespace/PseudoNamespaceToNamespaceRector/Fixture/skip_excluded_classes.php.inc b/...leWithoutNamespace/PseudoNamespaceToNamespaceRector/Fixture/skip_excluded_classes.php.inc
diff --git a/...ector/FileWithoutNamespace/PseudoNamespaceToNamespaceRector/Fixture/use_statement.php.inc b/...ector/FileWithoutNamespace/PseudoNamespaceToNamespaceRector/Fixture/use_statement.php.inc
diff --git a/...ming/Rector/FileWithoutNamespace/PseudoNamespaceToNamespaceRector/Fixture/var_doc.php.inc b/...ming/Rector/FileWithoutNamespace/PseudoNamespaceToNamespaceRector/Fixture/var_doc.php.inc
diff --git a/...ithoutNamespace/PseudoNamespaceToNamespaceRector/PseudoNamespaceToNamespaceRectorTest.php b/...ithoutNamespace/PseudoNamespaceToNamespaceRector/PseudoNamespaceToNamespaceRectorTest.php
diff --git a/...eWithoutNamespace/PseudoNamespaceToNamespaceRector/Source/PHPUnit_Framework_Something.php b/...eWithoutNamespace/PseudoNamespaceToNamespaceRector/Source/PHPUnit_Framework_Something.php
diff --git a/...leWithoutNamespace/PseudoNamespaceToNamespaceRector/Source/PHPUnit_Framework_TestCase.php b/...leWithoutNamespace/PseudoNamespaceToNamespaceRector/Source/PHPUnit_Framework_TestCase.php